Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <26c2fb0c-e58a-5864-4256-f60f948ca634@gmail.com>
Date:   Thu, 5 May 2022 18:47:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of
 MT8192 clock
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>, matthias.bgg@kernel.org
Cc:     mturquette@baylibre.com, sboyd@kernel.org,
        allen-kh.cheng@mediatek.com, weiyi.lu@mediatek.com,
        chun-jie.chen@mediatek.com, linux-kernel@vger.kernel.org,
        ikjn@chromium.org, miles.chen@mediatek.com,
        linux-mediatek@lists.infradead.org,
        krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        angelogioacchino.delregno@collabora.com,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        devicetree@vger.kernel.org
References: <20220429123133.28869-1-matthias.bgg@kernel.org>
 <20220429123133.28869-2-matthias.bgg@kernel.org>
 <YnGjScfQA9axBYBO@robh.at.kernel.org>
From:   Matthias Brugger <matthias.bgg@gmail.com>
In-Reply-To: <YnGjScfQA9axBYBO@robh.at.kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
> 
> An ABI break is okay because ...?
> 

Because the code controlling the clock gate was moved to the consumer. This node 
did never ever represent any working implementation of a peripheral. Just a 
lonely clock gate that wasn't used.

Regards,
Matthias

>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>>   .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>>             - mediatek,mt8192-imp_iic_wrap_w
>>             - mediatek,mt8192-imp_iic_wrap_n
>>             - mediatek,mt8192-msdc_top
>> -          - mediatek,mt8192-msdc
>>             - mediatek,mt8192-mfgcfg
>>             - mediatek,mt8192-imgsys
>>             - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>>           #clock-cells = <1>;
>>       };
>>   
>> -  - |
>> -    msdc: clock-controller@11f60000 {
>> -        compatible = "mediatek,mt8192-msdc";
>> -        reg = <0x11f60000 0x1000>;
>> -        #clock-cells = <1>;
>> -    };
>> -
>>     - |
>>       mfgcfg: clock-controller@13fbf000 {
>>           compatible = "mediatek,mt8192-mfgcfg";
>> -- 
>> 2.34.1
>>
>>