Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2122885iob; Thu, 5 May 2022 16:31:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkQUo62F0Q+Xo7FvGYU60HHWon6rk9kdcqZaj2b7/rBqEzX8T41T1sNscph/8PeSQG+1RU X-Received: by 2002:a05:6402:1a42:b0:424:20bb:3e37 with SMTP id bf2-20020a0564021a4200b0042420bb3e37mr623981edb.29.1651793512682; Thu, 05 May 2022 16:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651793512; cv=none; d=google.com; s=arc-20160816; b=l4eUlQwQrRdHcij6gscBX6p0Z76K/qEnf78sK1Yd6M8L2DodKRcu/JmN7EwMe+Y+Iq PtXWM13YXuWEXbL4GXxv405z67uzF303axoEkXWOrRwO8TUQEp9iEzl4nbbPE+l8FIZx qqZwTDmAeV/zg6/4iPgxRWh3IU7TTJ2WEVICHxMgUDfvzTdKl7JwBzgAwqw8IkE6HEG1 k1o8c7hX0ff5laO/IbwwSosiT5nKO214za+0SZpXnirrkzO5gf6iVcnxDbnykCn+2d4s xekjRLJUQBQgervetANWPhC84UacMthsJTDT271Jt7t2igMU16g7Rx/sDrCBPdcc7tHm ExGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=OK/Y9RXIwX4WSPb1yVnJ+oXwRv1Y1FzBcQ2JiQBwd90=; b=Ljg4PtidMLWiG35b+Z6AEoPxWS4whfn8S2i7O4+DshPX82mhog6RjVzJcD1cR4tVnG KOdb/VFAaXXFOJdk4bmkpMt2/E5Ih2tD/hj5gNfvmsTETxDPZmJAERXjhoYUfFrJtgip oaEREM0XhlF8zGz7fevJkMY+yGmomNIDjNX9dcwFkcd3RE7VBaGjy1dAC9Qxf925V91j nT/9MQuwy2+S1OW488k5yZbGJ/6H8qmntnNhpd65wvUEHgKoizTWssa69oNrx+RCmcuA aO7N3nsPstNun79JYklBjOEftSJVJZIY5BzHxkYnyQkqZo8n/v3rdsn/EEl9cxrTfFGW i5OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=osKma1W+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w15-20020a056402268f00b00427bf23f728si3724755edd.288.2022.05.05.16.31.29; Thu, 05 May 2022 16:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=osKma1W+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240873AbiEEDUT (ORCPT + 99 others); Wed, 4 May 2022 23:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240743AbiEEDUO (ORCPT ); Wed, 4 May 2022 23:20:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 655011F9; Wed, 4 May 2022 20:16:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1803DB82B1D; Thu, 5 May 2022 03:16:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B490C385AC; Thu, 5 May 2022 03:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651720593; bh=EUd+FQNjVhYPHngnfqRNiGUw9qP+rE/n5F5xlcFB4Ak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=osKma1W+URS/BXiFLBUBrRLnfzM0rDplolvKg/BjR0bm3FHE5uE+C2NU708HyQ89F CUBMXtrBVEFTjucpC/AcE9N5QZD/rh2rdkLHVGk1nmdA00hBYPtc0YVPQLpGlxuWxW URodyeuI0ii3rwQ9mY/rrbZFZpr0IR5QHL9+1aPbae/Nc95nCjEQ+xEGAUmIkHs+NU KyGuFyN3bS91qsRcJVr6RbnCwEOCKezOJhdogyy9UZjTJ8aH+HboHARRWS9KMgJMRv qrn59pYhUlQ/5DWID99rUS7REILjpq0l+CWu5/Ko3C7/+oxBNC3AnRyGqzyGcEIsvk ndS1OFXM1iydg== Date: Wed, 4 May 2022 20:16:32 -0700 From: Jakub Kicinski To: Maximilian Heyne Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Paolo Abeni , , , Subject: Re: [PATCH net-next v2] drivers, ixgbe: show VF statistics Message-ID: <20220504201632.2a41a3b9@kernel.org> In-Reply-To: <20220503150017.16148-1-mheyne@amazon.de> References: <20220503150017.16148-1-mheyne@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 May 2022 15:00:17 +0000 Maximilian Heyne wrote: > + for (i = 0; i < adapter->num_vfs; i++) { > + ethtool_sprintf(&p, "VF %u Rx Packets", i); > + ethtool_sprintf(&p, "VF %u Rx Bytes", i); > + ethtool_sprintf(&p, "VF %u Tx Packets", i); > + ethtool_sprintf(&p, "VF %u Tx Bytes", i); > + ethtool_sprintf(&p, "VF %u MC Packets", i); > + } Please drop the ethtool stats. We've been trying to avoid duplicating the same stats in ethtool and iproute2 for a while now.