Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e2eef6eb-30eb-8d18-a24a-a66c5023302f@amd.com>
Date:   Fri, 6 May 2022 00:25:28 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org
Cc:     Lewis.Carroll@amd.com, Mario.Limonciello@amd.com,
        gautham.shenoy@amd.com, Ananth.Narayan@amd.com, bharata@amd.com,
        len.brown@intel.com, x86@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, peterz@infradead.org, chang.seok.bae@intel.com,
        keescook@chromium.org, metze@samba.org, zhengqi.arch@bytedance.com,
        mark.rutland@arm.com, puwen@hygon.cn, rafael.j.wysocki@intel.com,
        andrew.cooper3@citrix.com, jing2.liu@intel.com,
        jmattson@google.com, pawan.kumar.gupta@linux.intel.com
References: <20220505104856.452311-1-wyes.karny@amd.com>
 <20220505110429.453279-1-wyes.karny@amd.com>
 <ce377229-06ee-7f68-ca55-361a8986a7e7@intel.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <ce377229-06ee-7f68-ca55-361a8986a7e7@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEx4NjBNNFB0M01oaXNPOWh0THczZEljQ0VCV00yYWpGVVkxY2xtRFZlQWty?=
 =?utf-8?B?UjRDMk11T25uYVFZMXpLVlptV0lqZmNpRW0xTncrZk1CNlJKZzhoam5zUGNx?=
 =?utf-8?B?RitXakVCTmtLMllWVHAwd1hzUnBMbHhmM3pNSjZHOC8yd1dtR2xnKzBZNkZJ?=
 =?utf-8?B?ZXdQVXVodm1GS2I3QkFzVzV3ZFFSUWtsZ0JqcWdYell6RlZSWEJtaHlpK2tu?=
 =?utf-8?B?dVNBWWw2eHVuaE5ReTlxY1Y5S0NFZWJQVnR6UWRCMWltbjJRV0grN3c0OSto?=
 =?utf-8?B?YVJYbVZBOXhCUE0yWk5jaFNjcytLYzlvN1dHa0NOQ0xraWZtcmc4dWhrMTVv?=
 =?utf-8?B?NUV6RzVVcGtLSmxyb0J0MDlRTEtOZTExbkF6dGI5dmpKUU9XVVlaeklrTjdp?=
 =?utf-8?B?VlJVcmZiU05LNHZGcmJJU0tZUlN6Z0w4cFhydUtTQUcrTVhqWU9ZY0o1eG40?=
 =?utf-8?B?ZWE3SENBVmorLy9vbVJQeHlmeHI5N25UOHNjSFkwQ3BaQmxpaU9MdVZiR2FK?=
 =?utf-8?B?d0Zxc1VXVlExV09RVUhyYkFMckdUcHprU2JreWRHSGg1bTlLaE5YdFVjZXI2?=
 =?utf-8?B?VjFUb2pIM0czN0dDVExObkxaZGE5b2VzUXNhTFZCMTZZWXB3K1VsVjV4Mkpq?=
 =?utf-8?B?ZmQ0bGZ0YjcrS2FBN1ZOclhsUHB0R0V3RnF5a2duU1FQeXNNMHF4Nmc1c3lZ?=
 =?utf-8?B?QkJPeEVGUnhlVUxmZUFiTEpneTNSQi9saWIxeER3TytaNkhzN3ZtRk50Tm0r?=
 =?utf-8?B?dlZNZmFXN3JCREJwNXUrR2R2dXQvNmhpN1NjRG5ERG5lb2cyNVBGNTBXRWlF?=
 =?utf-8?B?TFBEQTM1bTlISHJvS0JqQWg5c2VpMjVucDZJQXRaNnZsZGdNYXArenBXOTFK?=
 =?utf-8?B?V3hZUnZ0VXJJV1N2T01pMVRKNlVPNzkwRnVqUDlGNzMxRnEwUjB6NXhweEtV?=
 =?utf-8?B?TUJsWmdabHVZbmV2SkliUjlabjdZWUNRNEYvNlZtald4TGxadGtkWmYwRWMz?=
 =?utf-8?B?SEJmeGpnOU5VWVowZU9peExrMFg4R3k0QTdtcWJpQ1NZRFZGQ3RiYlRPOUkx?=
 =?utf-8?B?YmdzZFU1TnE3aGptZ2F4MHM0UFpheHM3RUZuWUROWTVldk95bWNRUnU1c3Fr?=
 =?utf-8?B?TlJLSmhLdmhzdEhqNGUwNHJNcXBJSUFZa0JkWXhZNWgwNHEycndPMkVyRHhs?=
 =?utf-8?B?UzdHVE9HYkxmTUNONlNRYnFLU0NYSHZpUG5BQ1E0MzR2QkluOFNyR0dMYWNx?=
 =?utf-8?B?K0Y2bCtQN3RtckVGS3c0d2R6bUQ5Z0cxcjhyaGtxYXJ0NlNQSXZpYjlSYVZV?=
 =?utf-8?B?UG9UWUVudkxoeDVuNlVZRkV2K2JiQkFMM2xWOFZRbVZWay8zVStBTGZ1Q2Jv?=
 =?utf-8?B?Um9lM1VxKzh4c2JPRFQvNWZ1N1c2Mzhqb2MvSWFkTjUxaUlvczBYay8wNWV1?=
 =?utf-8?B?QXBLOXpsTkZwS2dzT0g2d3FXUkpURU5jYk5EbUpBWnBxWVdmYzVuOWR5ay9X?=
 =?utf-8?B?Zm4rQnJ2UFh2RFpkcWtPL1JRWm9jKzBZUDNvRmQwWTVRNXVyQzhKZE1zaG5o?=
 =?utf-8?B?UFY5TUE5cGE4dlAxSms3enNLTmg2YkdtZEVjSDcwNGFTckQvaUhwM2dEcFlQ?=
 =?utf-8?B?cFBVNDlaQVhTVzdPSUtHVnNDZW5oVGlPTXQ2Y1gxQnZ6NmYzUGJGUEFCSXRW?=
 =?utf-8?B?d2J4VFk5MlpjalVYZFFzSDh2ZFlGUUNvOEtZZEY2VkRsTnFzSXZENFFWcjFW?=
 =?utf-8?B?RU83dHpJNWR5VGRpejM0Qi9MaE15elordTZ3UlQ0c3d3N29iTE81Z3EzaHo2?=
 =?utf-8?B?dUJWK3hYajYwL1crV2lpeDM3VGFiaTR3cmdXeXpBSEoybzVrUUhIYS9YSjNa?=
 =?utf-8?B?ZFk4U2RvbDZpWTN5OCtxT1pPNHFQaHZ3UlV5L05yTmNKbUxrSVFnWUN1NG9V?=
 =?utf-8?B?Rm1RUFlPZDVYdDhwQWFCZWk1VDJ1SEpaeVk3OWh5UU1HMldaaWNZNllickhG?=
 =?utf-8?B?N1I4U3JVM3BUNk9Zb2xQVU9ibHZ5YjRHUTlvYzZTQ1FLOHBQdW1jM3pWbkda?=
 =?utf-8?B?RWpDU3YvU3piN1hvdXA2ZkhTZlZWYnlocEYyTTA1OStKbjR6a3lOQ3NxN0sr?=
 =?utf-8?B?aHBnRE9IV01lWXRsbVdSQnVGVENpTFVrWng1anovWjJYUzA0MWthbXNpR1oy?=
 =?utf-8?B?Ynd2Uk5BQ281ZWQ0MEswZEZtZ3VPditIRzFaMFZoNEVUN1dOT3RTYWpWUnM1?=
 =?utf-8?B?L0dWTVFxMC8wTnNERjJRY2RNR0t5MHJxZnVoMGx5QldmdFJteFNsOUlHVDFI?=
 =?utf-8?B?RDYxd0Q0UUhJYlFPM2V5S0FxbFdZS2N6UTlWVmwyNStBZ085Mmo5QT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad1948b9-12a1-438d-15f9-08da2ec8ddaa
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3368.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 18:55:47.8750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qt59OjYgHYY0eK307Iy3Cydj/STFX7NI1109jzcbLldSZ5iS9ep3xLzCiyFwq40S2jQ+nh7rtN7VHlsu2TtPsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3875
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Dave,

On 5/5/2022 10:40 PM, Dave Hansen wrote:
> On 5/5/22 04:04, Wyes Karny wrote:
>> The feature X86_FEATURE_ZEN implies that the CPU supports Zen
>> microarchitecture. Call this out explicitly in the comment.
> 
> Is "supports" the best word here?
> 
> A CPU is based on a microarchitecture, it doesn't really support it.  I
> guess we could say the CPU supports a microarchitecture's *features*,
> but that's a bit wordy for a tiny comment.
> 
> Maybe:
> 
> #define X86_FEATURE_ZEN			(7*32+28) /* "" CPU based on Zen uarch */

Thank you, Dave. Yes, "based on" could be a better choice here. I'll update this.

> 
> or spell out "microarchitecture" if there's room.

Thanks,
Wyes