Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Tianfei" <tianfei.zhang@intel.com>
To:     "Xu, Yilun" <yilun.xu@intel.com>
CC:     "Wu, Hao" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v4] uio: dfl: add HSSI subsystem feature id
Thread-Topic: [PATCH v4] uio: dfl: add HSSI subsystem feature id
Thread-Index: AQHYYBXhq0QLvnormUiUUyimXrfATK0Pi+KAgAB4fPA=
Date:   Thu, 5 May 2022 09:27:37 +0000
Message-ID: <BN9PR11MB5483A1C8F7C52E4331CAF8F9E3C29@BN9PR11MB5483.namprd11.prod.outlook.com>
References: <20220505001628.681226-1-tianfei.zhang@intel.com>
 <20220505021545.GA417720@yilunxu-OptiPlex-7050>
In-Reply-To: <20220505021545.GA417720@yilunxu-OptiPlex-7050>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.401.20
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xtYWB1nSBMw+Ww57z8mDsnMRA2yMjlf4/LNpan7fltSH6KUngUe0JwKhybAP?=
 =?us-ascii?Q?Pp5f/LvKihpRwMle3XFsNIF6ZBv/fSC4ofbgs4av2UrL7GtiDwuPr59JOTN6?=
 =?us-ascii?Q?TiQrj2p4KKIbSD0HQC/f8Yjp7gdwiqQc26mGqQEtr/qwjsMe36/FP4TNrMdK?=
 =?us-ascii?Q?cJYXE6YSdSASF7r0WJ39ouYPEcAku52quQgnm+7AbBpgnpjSkf/GptkZ/Mi7?=
 =?us-ascii?Q?kwjLp0ImOFSlMqkZa7ZWJ6Lck6rnliqr4ADALWCzSs9+H9ZyCIkzfmOCFJ45?=
 =?us-ascii?Q?JCdbi4MlI/iLa1CqSBLBxHdEsdhV+O3sktBnuwq3nbxowHiVCiK+2ZlcbS+a?=
 =?us-ascii?Q?wiGEhPzsCVrwaLJcB0gHd2XiAcYXK4aEl1MVXSzVJFzL/bKCZVvo5Y5qoJQK?=
 =?us-ascii?Q?PvSkythd0n9UuSM8Lyq24QcYP31UqMN3gcsojblreAHK1R0zfWvLWW2OKmtK?=
 =?us-ascii?Q?EW35TBbbydC6IJmvq/5eswMZimpDAI5V/KWy23s7Aro0uH0ulox1TGXr/duW?=
 =?us-ascii?Q?FZSQkrmMcqW7lRy+3vA1rqYsepx/ozQgL4WlPtQiph3cpWNf4md1jXo9uQIU?=
 =?us-ascii?Q?yTDKCUhBFDXWwWFiiNETO16A/jmzhK71plZ18/X/Y/job+zYV+1Wp/He/jj1?=
 =?us-ascii?Q?1BbGJaSmvMGaXFNRgzfVEyONoOJoIaKAlJiNAzMqzKQfXDLTEG4G+B5c0tDY?=
 =?us-ascii?Q?30RAiOydfEnHNhNNlETJlzVPVadlC49h9oJw8RjAF/qk1DKRC3bflkMFxE4l?=
 =?us-ascii?Q?j8imQSv4xL0OZzM0/GRvBRM14+KjHaCzQtqzoaMzLzBmVJNzvYRoZ5RxojID?=
 =?us-ascii?Q?WhJz4RVYvjQVEUC4zHvP4ZH5leDzq4ki+IdUsy6SRiC0FnGcOfaADFdkKO58?=
 =?us-ascii?Q?KCvNUj8lKmn4xpMunJlHuu55mrIP9l6xi0kDGVEYm42J97QurfdwhInfJ2DY?=
 =?us-ascii?Q?Oc1bBBRQwc1NrNW+sTXR3pwtVzYXkxKCbDsHU9N+YinSu4idYDyW1Eskys3L?=
 =?us-ascii?Q?lHkK5YIVC7bfSThsSaJBjz0AjVdLp25U9IBDgarhyr9LSZnlgKHP+4cO3s84?=
 =?us-ascii?Q?pCQCx9qxSas+CqIuDnp8Va8vfnCALzxiz5TOaLYwFBdHbXYA30b1hKdU9wLk?=
 =?us-ascii?Q?MAEZKsZh9qJUTMGbk4ybSCCZhRlxGicGLgDXqWyKJtVTCbxFNxWM9bBNKDap?=
 =?us-ascii?Q?91A4/3XHvaGVl9lGyKGv4PmXBm3X7Qma4AbtKd6dS5CAl0LHP89wKOC/KJfv?=
 =?us-ascii?Q?ltu/yz2VPAr/uBjR42WdJu34DkHSP+STmPjB2c1LN9As9zETXjPwIsMxR4T/?=
 =?us-ascii?Q?EWaDY3BZnAYjxAKqVCvHAZDGgSyap/UypZacj6PE+CR8Ms2xsvf1zgWSRay/?=
 =?us-ascii?Q?Bz2Bk1KvhLS7BLXi0Dl1HWfAGIXF6idgR0lixCi0ve9R//s+ssdmFN7713Ob?=
 =?us-ascii?Q?6AUQ8+SyAOFK9wcxNiHC8cyIPH9r9wf4sGAlYH8IaGNPeWeS0HbQnX48vXKp?=
 =?us-ascii?Q?Iw45pMQ0hugIMoaa4g16ZsmmtSx/jTA/uLdMzNbXiftjxO6go9zU7h155WFQ?=
 =?us-ascii?Q?e/+QsB5TksHkDJqqVe90wPb+NK2037uZH7VcwWxtDQoGd7Dgrt1m7KdfxS8s?=
 =?us-ascii?Q?Pw+AhlG9C9x/lx2XROxrxakJD/pRhJDadp5CtFoHxn5F7qtoYtUkilZ8yGMf?=
 =?us-ascii?Q?P9Q+XAZgU4K0tBBsjGzFvaIXMtjBzPNe4c1HgEUDoEzvZEl3nF2/yyCIOc6O?=
 =?us-ascii?Q?raa7ShOf9g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2937b3f1-4d29-409d-de6a-08da2e797e74
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2022 09:27:37.3230
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6pzyW5BC3VhowfdPrGaknmcaYnBLJ+ef3pxWDA+EfBzp55UOAPCzJ/yktbjGyuqHqSJClqMEdTztPC0hG7eSYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5592
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Xu, Yilun <yilun.xu@intel.com>
> Sent: Thursday, May 5, 2022 10:16 AM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>
> Cc: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> fpga@vger.kernel.org; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Subject: Re: [PATCH v4] uio: dfl: add HSSI subsystem feature id
>=20
> On Wed, May 04, 2022 at 08:16:28PM -0400, Tianfei Zhang wrote:
> > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >
> > Add the Device Feature List (DFL) feature id for the High Speed Serial
> > Interface (HSSI) Subsystem to the table of ids supported by the
> > uio_dfl driver.
> >
> > The HSSI Subsystem is a configurable set of IP blocks to be used as
> > part of a Ethernet or PCS/FEC/PMA pipeline.
> > Like the Ethernet group used by the N3000 card, the HSSI Subsystem
> > does not fully implement a network device from a Linux netdev
> > perspective and is controlled and monitored from user space software
> > via the uio interface.
> >
> > The Feature ID table of DFL can be found:
> > https://github.com/OPAE/dfl-feature-id
> >
> > Reviewed-by: Tom Rix <trix@redhat.com>
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
>=20
> Please re-order the tags. The earliest at the top and the latest at the b=
ottom.
>=20
> "SoB chains should reflect the **real** route a patch took as it was prop=
agated
> to the maintainers and ultimately to Linus, with the first SoB entry sign=
alling
> primary authorship of a single author."
>=20
> For more details, please refer to Documentation/process/submitting-patche=
s.rst
>=20
>=20
> For you case, I assume:
>=20
>   Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>   Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
>   Reviewed-by: Tom Rix <trix@redhat.com>
>   Acked-by: Xu Yilun <yilun.xu@intel.com>
>=20
> is it?

Yes, I agree, I will send a new one.

>=20
> Thanks,
> Yilun
>=20
>=20
> > ---
> > v4: add Reviewed-by and Acked-by tag and add Feature ID table url in gi=
t
> message.
> > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> >     the git message.
> > v2: add HSSI introduction and the git repo of Feature ID table.
> > ---
> >  drivers/uio/uio_dfl.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > 89c0fc7b0cbc..8f39cc8bb034 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > }
> >
> >  #define FME_FEATURE_ID_ETH_GROUP	0x10
> > +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
> >
> >  static const struct dfl_device_id uio_dfl_ids[] =3D {
> >  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> > --
> > 2.26.2