Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2183903iob; Thu, 5 May 2022 18:17:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqDZ2R2BGrg9Cj2EWbQUO7FgQAgjJ2Rz1jhkTL59D0jdK+wLq1E9Oq7keB9sctBv6RYRBf X-Received: by 2002:a05:6402:17c7:b0:425:d52c:8907 with SMTP id s7-20020a05640217c700b00425d52c8907mr998265edy.15.1651799856840; Thu, 05 May 2022 18:17:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651799856; cv=none; d=google.com; s=arc-20160816; b=MMiTmHbQcXee2LIa6S9/w+6mJbivKGHa3Ru9SCMTR/qYK41lE5fjWQ0dXp6KZU/St7 lAyiBDIKAa8YyaaFvIzBhM8vR7wvkqYKVOU2BJL8sjHBgAfKSp0E2to1z7En+hHe35OT l4z/GLmxKORxdTpVa3R5Y6BkDaVdLh6jJvL+rpXprYTC6wUyydasr7JDLlLS4wHhKOSC tF7PygvI2mF470VAM+0HppqN+w+/XDmeu1pYIwKsGSa9eBK355JDwmaN/0hnk+UKqaj8 bs+5UU3hz1Q4F2QOn7/PJUtP9DHtbolXyndNGxkpXzoY65SKO9wwafX/C0/s0/byIVKz o60Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=celaTRkVpp+EsOunIyeRNlH5q6ru1fC3BGlnsF4vB84=; b=EG1wGk9PHWVqsKSOr5Lvzpiq5cZ9ZWC0I/AJaCcz9glVQHER9Uk5svDZLe1XTVbC45 mFOCe9G06Z0fRvjVssiu9545SB2LqVj2yyyG/n4BPFn9SprZyXxi2BdM8Er0pST9XcCy hlDl5X5DYQtFnkcJ9DxQikMZOREfh0ARwYuMV6BmXf+3IvXy3n0903vweOVLVuayvXor DXIS4A0UoFcZLe+F2fDy5677pYOnHXNnX2KKEUoRaEZTCQ/LScNYbWgwM6BtfWLiSDlh +uclXBC3bJojcnjOBLJwuYlHGTQe4YPfXh0ojnPH+M1pJeFYshC3FcMATFVjCDBAtE4t djhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Aw8O+QLL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y20-20020a170906071400b006f4fc3a077esi2663631ejb.676.2022.05.05.18.17.13; Thu, 05 May 2022 18:17:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Aw8O+QLL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358661AbiEDRQK (ORCPT + 99 others); Wed, 4 May 2022 13:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355754AbiEDREl (ORCPT ); Wed, 4 May 2022 13:04:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 368CE4F9CF; Wed, 4 May 2022 09:53:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D953AB82792; Wed, 4 May 2022 16:53:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89E29C385AA; Wed, 4 May 2022 16:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683198; bh=T+6fF+nirKGVpbNshmrpy1TVjrUpgYnSA/GMh703wqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Aw8O+QLLCtDWcaybUsbAZRSR2bH1QNS82h6ab9+b/7blQoyPL7X0u4AEOm/I/6wUz gThwYKUl98m9CdnyhyTHKqhL1sRr26VkwdG0iOIkXdIio8sf2Jzb2SuLsZ5nIFpeDR pP1QZyB7lBt1sFr47T5tTuy5G8XQFgFTscMEODvk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Vinod Koul , Sasha Levin Subject: [PATCH 5.15 063/177] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks Date: Wed, 4 May 2022 18:44:16 +0200 Message-Id: <20220504153058.650300170@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153053.873100034@linuxfoundation.org> References: <20220504153053.873100034@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 3588060befff75ff39fab7122b94c6fb3148fcda ] The corresponding API for clk_prepare_enable is clk_disable_unprepare. Make sure that the clock is unprepared on exit by changing clk_disable to clk_disable_unprepare. Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220318105748.19532-1-linmq006@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/ti/phy-omap-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c index ebceb1520ce8..ca8532a3f193 100644 --- a/drivers/phy/ti/phy-omap-usb2.c +++ b/drivers/phy/ti/phy-omap-usb2.c @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy) return 0; err1: - clk_disable(phy->wkupclk); + clk_disable_unprepare(phy->wkupclk); err0: return ret; -- 2.35.1