To: Paul Mundt <lethal@linux-sh.org>
Cc: Roland Dreier <rolandd@cisco.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.
References: <20070510035028.GA26453@linux-sh.org>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 10 May 2007 04:42:37 -0700
In-Reply-To: <20070510035028.GA26453@linux-sh.org> (Paul Mundt's message of "Thu, 10 May 2007 12:50:28 +0900")
Message-ID: <aday7jw29ci.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1173
Lines: 27

 > CONFIG_MLX4_DEBUG works out to a def_bool y for those that
 > have CONFIG_EMBEDDED set. Make it depend on MLX4_CORE..

Thanks, applied...  (by the way, this bug just results in an
extraneous CONFIG variable being defined, right?  There's no further
breakage -- or am I misunderstanding the situation?)

 > I'll let someone else wonder why debugging output is default enabled,
 > this seems to be a worrying trend as of late.

Actually this option just controls whether to build the debugging
output at all.  The output is controlled at runtime with a module
parameter (which can be changed via sysfs after the module is loaded),
and the output defaults to off.

The reason why I want building the debugging stuff to default to y is
so that distros automatically build modules with debugging enabled.
Otherwise it's a pain to try and gather info from someone who has
problems with a kernel they didn't build.

Thanks,
  Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/