Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2233556iob; Thu, 5 May 2022 20:02:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDCAs6GM4j3WiMwGkpwVIv0pzoG31p5nmapJEoO402JHrQeLQNqWiUHi2OqvcTkTPpFMJC X-Received: by 2002:a17:907:7247:b0:6f4:ed49:cd3f with SMTP id ds7-20020a170907724700b006f4ed49cd3fmr1204870ejc.172.1651806147856; Thu, 05 May 2022 20:02:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651806147; cv=none; d=google.com; s=arc-20160816; b=yhK1TmrlMODMI3PEsPRSKrgZ8b6tcyl06wMKGrNHkMWnKTuod6wqXWwIwPrlbEGD9A YOOqwA5Byq4qbpxuyArFvGo117c+5rg7es1OrjU2il9FvWW8Ohy7r9CDEfU3u0Va3dCB qU7XWbwNF3iZJECWxrFbh/pXsHYhxvSP8WJsDoW+gsIXhqzCHLOY+ZQIJlPF9xk3XFLO ojw2vBamiufEOp5F7aiuhIcnyZvFWpiQ1K2nJC1Qyi8seStPCHQC5sHEpMOR6FFUtUg2 V327dZb6Ay6IKfFYIZ+No20U/APAmEYjcH1TSWMxIxLqBUwp/Lq3HHLszAlHF3NBtEBb OKbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rKFwpfuxfVzydPoCDdRgnMWu26LIScgGhNEjJVqgBng=; b=UfXJmFUz9YK8e2+uVN11+mIoOaRmBLoYcktry8PtXmY9AxRgqSjJZUQaP4QcmifGsN INrG7bR+PZXCIzetbth9S9MuPLY/FtC5lpERZ7Z4uE9ROiLJb2OIupU466FKwPCImPyv Zt8bLB3CpBtkMHsDDkDdbQeJVzEeBgHK6fmORUE1l2uRQO5c23MC/GUNgSlJrQOEC7Ec HcHapyK3Ib1gdVSoKAQwYvU5cOnFIvgP3o/dNvOY4SLEb21YKbyNic+YJP0BMCyFyUnD 5PGgwbQnVAxcPOF8ys7nPIzIO7TWllVDRd6sAfNBE3wnG8PWcabbttChuL/5sx0t+8ni TLTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jj8xPB5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a05640250ca00b00425d8c74949si4302851edb.417.2022.05.05.20.02.04; Thu, 05 May 2022 20:02:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jj8xPB5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356152AbiEDRLT (ORCPT + 99 others); Wed, 4 May 2022 13:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355404AbiEDRAC (ORCPT ); Wed, 4 May 2022 13:00:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 409684B402; Wed, 4 May 2022 09:51:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DAE9861811; Wed, 4 May 2022 16:51:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38215C385A5; Wed, 4 May 2022 16:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683090; bh=MAiGjYL2OG/xAAB6sKyAI75CanTT2wYUIKRLSJy6lhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jj8xPB5ZrEkSVgZLnOg/6TEtLxVzb1Z78fLh8xJI0oH0NKbYsTYByeLruEOCOIfy6 oELZCLjaFoEf5/BCzn89lA9orjLlxJslkBtrQvEqHgwFBok1lrY94vSlgNfkF9OKMg PwFKPpCeX1ad7qz0EXoCjjpaWIecGKPpaIco46hI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 094/129] net: fec: add missing of_node_put() in fec_enet_init_stop_mode() Date: Wed, 4 May 2022 18:44:46 +0200 Message-Id: <20220504153028.392897634@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153021.299025455@linuxfoundation.org> References: <20220504153021.299025455@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit d2b52ec056d5bddb055c8f21d7489a23548d0838 ] Put device node in error path in fec_enet_init_stop_mode(). Fixes: 8a448bf832af ("net: ethernet: fec: move GPR register offset and bit into DT") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220426125231.375688-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 166bc3f3b34c..d8bdaf2e5365 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3529,7 +3529,7 @@ static int fec_enet_init_stop_mode(struct fec_enet_private *fep, ARRAY_SIZE(out_val)); if (ret) { dev_dbg(&fep->pdev->dev, "no stop mode property\n"); - return ret; + goto out; } fep->stop_gpr.gpr = syscon_node_to_regmap(gpr_np); -- 2.35.1