Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v9 46/69] acct: use VMA iterator instead of linked list
Thread-Topic: [PATCH v9 46/69] acct: use VMA iterator instead of linked list
Thread-Index: AQHYX1Q8M1ImekAzhkSm96/WKPCN8w==
Date:   Wed, 4 May 2022 01:14:00 +0000
Message-ID: <20220504011345.662299-31-Liam.Howlett@oracle.com>
References: <20220504002554.654642-1-Liam.Howlett@oracle.com>
 <20220504011345.662299-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220504011345.662299-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?BxvUx1Jx9fxF85jOQ5LawNehNx8GZRUrGvlLocKsakTuPu7op/E4kdhPaT?=
 =?iso-8859-1?Q?WuO665FGkbAJ4I+66Ib9z/xI6yOV0r23GZWtVs81pNiFZeeX/XNhHZqqGI?=
 =?iso-8859-1?Q?gznV0z1EMUfc10CRbWYKIrTIyppf6GbSL7t5kZlHDqF0K2fnCghenqwk5y?=
 =?iso-8859-1?Q?AU9OMTLNj2RWqsHEh5cGuVj5W4HJR2aVM5O2B0XKrJqC/MBObcym2cTSNT?=
 =?iso-8859-1?Q?zgF3jrE2ABwL2LSSdFRkATUODJSuJgvKoD6XSlBDWwB4PPNt9KGuMKg+Zz?=
 =?iso-8859-1?Q?DedXN5WXUJP2OQJHbbrS5H76EnP9r1e8Zuu+dEJUcIja4Hf/LE6t+DFjEm?=
 =?iso-8859-1?Q?2MR8TRugXdei+rXC07i8+mHT3DeLB74sM6V3TUFemj23qs6Pmm4gUiVHfi?=
 =?iso-8859-1?Q?lMSWm30S2SkvvABSOZnzq/M1LWmbWB1iCCW2SihmEbPwau+Eq4NPM53PXc?=
 =?iso-8859-1?Q?Sm5w6OPzensDCfAtQvpjWeYgTQZk+845/yrPtVGzrXjJpQw6TuOXVI1mBA?=
 =?iso-8859-1?Q?ck+m4TNN83idD8UbtTkmtIQzPahFMW2eyEslKta1JFyfcalasPxc6QJCY4?=
 =?iso-8859-1?Q?FX7UFkommk0FBFwNPMearuaRY0rMa/oo8UMpVYp/9mr+IRNVprm02jpz3l?=
 =?iso-8859-1?Q?nSaQLBptuUYWFUMD9SeX3Uaa1sPqGLfeim+ROrQqd3AheisyMAXp9e6/S/?=
 =?iso-8859-1?Q?UtHZF+8QL1bo4XJeGi/SR7P2DkYLaI9JFJiMhSwJHTvWvvSy02IJY3xuId?=
 =?iso-8859-1?Q?NWjZM8W5A7XWhuySUCZ7G9aZ5iTgvLfLZWPyETmhISmYQ+jjHp/523Er5R?=
 =?iso-8859-1?Q?HL7JmaBWuzGsQxCYhG8+xjCNqxEN4gmvWtfI1X1Gw2r7bvHnWVS4QIwWvS?=
 =?iso-8859-1?Q?xAPUwTzqJlsWyPTFER1M15v16mGb7KKvDjsjYn6ytthWIkRT73MprV7n73?=
 =?iso-8859-1?Q?t+PJQfNunnrN2ED4yjJRADYfVlz2EOanfsmzyyFqy/L4TJQXbxTBl+kEJP?=
 =?iso-8859-1?Q?sa58Yx3imG/BvVmh6otfE6ecvxYIbfp9y4KphS3GN6fH6dJeR90Tv32dZg?=
 =?iso-8859-1?Q?ioGojnj3oyr4jLOp2zRDaafTm1PpzZiXv0IteN0ZWmZc32vhvJmPwp9Hn7?=
 =?iso-8859-1?Q?Qsd6NEVNRJj4IeiQIlhf4xz+5vgppr0SANiJh5OZiMuKoLr5dQ0jv9S4VY?=
 =?iso-8859-1?Q?IpbscdnsM18V+rYGuxRJI0Lj1qEMUrCKXubBrrFZsMmitS80tdKAkAnWrT?=
 =?iso-8859-1?Q?amNV01Ma+r57n3tTvSpvciW5YwRGC8GXnn1VNO7SB4YG9jdzT6fX7SsBGy?=
 =?iso-8859-1?Q?kjz+RIJ9S59R1t2aNhpJBiPvW8qxf+ytdio671eE2mx0ZcsjwF0i+HOrDe?=
 =?iso-8859-1?Q?1TQnR2wllh0jgpfi86gNzAkfbJbzP1AKbBoaNV4P+26BSdVAgh48LqQbYT?=
 =?iso-8859-1?Q?puG386GrMm23knmlxr4/Az98sfbqF0IagR+755qquvNXI7oZFPpyKMm5sh?=
 =?iso-8859-1?Q?XQHUllqsFxzUOmS2sjCt1Tqy2IxfMNUGgHwuA8TaNh7EdciR/MXQs6C38G?=
 =?iso-8859-1?Q?khiohPaXAjuKvNbJtjQ88naOtYrtql2lo6E485gTTHvrjcpBPr68KkBadJ?=
 =?iso-8859-1?Q?vOZjGZbxRXskLQXS7+bAjWD1LNhG4lGxB4suE6B0XtKWI4HUS95Sar68QU?=
 =?iso-8859-1?Q?bud7JaECPBRzMoRZ9JHO3mFivB/G05znkfYAutvFEPQ6jYeTE3cvOpLlBx?=
 =?iso-8859-1?Q?a+/8PlIHZXKif6Ywi0doueORWRFw1KJbzDq1UvpYnSTO9ZEosBnLYDGYjY?=
 =?iso-8859-1?Q?UfMIIFCCS4IJh4LJztt3vXVr5vR18fQ=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56039387-79ae-41f5-d242-08da2d6b7331
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 01:14:00.2358
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jh87cMrcRTUu66LUsBj20+f6nBYII11KMobKYRQIlVxqWST/j5c3JO4xkOfZnseZz0FBec1jQTWr5M8gGhUBpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3728
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-03_10:2022-05-02,2022-05-03 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205040006
X-Proofpoint-GUID: UrA5vxtjO32hUMkffBjF7IsCIwZUEaxZ
X-Proofpoint-ORIG-GUID: UrA5vxtjO32hUMkffBjF7IsCIwZUEaxZ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 kernel/acct.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 3df53cf1dcd5..2e7bf8d41f04 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -535,15 +535,14 @@ void acct_collect(long exitcode, int group_dead)
 	unsigned long vsize =3D 0;
=20
 	if (group_dead && current->mm) {
+		struct mm_struct *mm =3D current->mm;
+		VMA_ITERATOR(vmi, mm, 0);
 		struct vm_area_struct *vma;
=20
-		mmap_read_lock(current->mm);
-		vma =3D current->mm->mmap;
-		while (vma) {
+		mmap_read_lock(mm);
+		for_each_vma(vmi, vma)
 			vsize +=3D vma->vm_end - vma->vm_start;
-			vma =3D vma->vm_next;
-		}
-		mmap_read_unlock(current->mm);
+		mmap_read_unlock(mm);
 	}
=20
 	spin_lock_irq(&current->sighand->siglock);
--=20
2.35.1