Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2434180iob; Fri, 6 May 2022 02:48:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9qzG3Eg+hxct9F+r4Ub3fIADjLsKM77nyRe085koYx8zkV0++UB8oM/zofhgNyv1YGQOG X-Received: by 2002:a05:6402:1394:b0:427:e7a5:b8d0 with SMTP id b20-20020a056402139400b00427e7a5b8d0mr2539680edv.9.1651830536196; Fri, 06 May 2022 02:48:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651830536; cv=none; d=google.com; s=arc-20160816; b=0JDWojxS6khLTcQ7nYEf0Lv3BRGF/a1GpXgzmsXvkqYwd8h8xx6FaKfHYnieOk4emY VYWwySWnwhWJ9FZAOW4uVArE22EFL0pgucpwOw1UYt8ZafVVDJF+uOJVp2BDKZMUCUlO U785pYp6rkr3BsI9HlMVyFWzJxa62KcTTpL/0xMD8v1e5SZuufZXKGxvCFGVpscK1a8a vXAw9aMESzkun8jSyN9E4vWLyBCbNLZKb773MCaa0Wr8BkVxCFiBJuL/+wQY93FHTbFK MBJLYHjzD0hTDQ53Q5PefEKKJWHRfA3M/chtgJoeWrcCBJiMEfEnRAxqOq5l7n376XMD iVdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=u9tThLrf34JY6fvaYOVITuYyqLOBm4qLqJzDkMXFAP4=; b=QCH1P6sbPsaEVu5xp3GHi4GzhBaqkTbJRoQTfhCDHnr7aGIiWlgPHpZPqe8B8LB2if gGHhPZSfBcRaIh9jDtrkKIzdkPwTKwy9+WNcllb3sABPzMC8hxTTbTcOP7FmnfpIv4AU iiE88LUKO3k4iy/QfllJOHxBXVbZ80l3Rdiy1XU32CXlc2149zKSmWRpkHCzeVoqwXdD fQEf+T4myYc3+2F9JKxvhrzNdwlMWAqOwu7XlJ/UGpkm6rQr5G4oacu31+xR09nhKQoP ru7mjJw3MLPULL1fOophGM6mAM8CuzzBSzWZu/smXBDAvRQR2aTljSTgLT1flDGXxbrO J2UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MJacyXw5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m2-20020a1709061ec200b006e801269d02si4377422ejj.240.2022.05.06.02.48.32; Fri, 06 May 2022 02:48:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MJacyXw5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382786AbiEERnr (ORCPT + 99 others); Thu, 5 May 2022 13:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382768AbiEERnl (ORCPT ); Thu, 5 May 2022 13:43:41 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701765BE46 for ; Thu, 5 May 2022 10:40:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CCAFCCE2ED7 for ; Thu, 5 May 2022 17:39:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0861C385A8; Thu, 5 May 2022 17:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651772398; bh=Fea/rsoxEnUkTCcBFJAwvQ9RkVxQQI5m8J3zJBHz8TE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJacyXw5JQdV1zxZ6e/r0qhwiQ+k9EW9VNgnv6ulXAQEKa+weAJyctY+gywsr4JPE 9N0/t+LD3x8bdacDkRd6+rFAYvjPnHJX4mwFjH2oujFKe34RRPzFp1eDpk5f7UseK3 qEPJngQfmEl1LHxs7NInu4wJGfSJLUD4z6ajdnl0= Date: Thu, 5 May 2022 14:23:12 +0200 From: Greg KH To: "zhangjianhua (E)" Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] vt: defkeymap.c_shipped remove unused variables Message-ID: References: <20220429014814.988829-1-chris.zjh@huawei.com> <53e36000-ad70-9de7-74ad-16bd81dae530@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53e36000-ad70-9de7-74ad-16bd81dae530@huawei.com> X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 11:10:55AM +0800, zhangjianhua (E) wrote: > > 在 2022/4/29 14:39, Greg KH 写道: > > On Fri, Apr 29, 2022 at 09:48:14AM +0800, Zhang Jianhua wrote: > > > The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have > > > been initialized but not used, they are redundant and remove them. > > > > > > -------- > > Why this extra "------" line? > > This line "------" means the end of commit message, if it is redundant, I will remove it in next version. That is not used in kernel changelogs at all, sorry. Please don't add it in future changes either. thanks, greg k-h