Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 May 2022 18:57:42 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Min Li <min.li.xe@renesas.com>
Cc:     richardcochran@gmail.com, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v4 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS
 support
Message-ID: <20220505185742.1246d738@kernel.org>
In-Reply-To: <1651697455-1588-1-git-send-email-min.li.xe@renesas.com>
References: <1651697455-1588-1-git-send-email-min.li.xe@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed,  4 May 2022 16:50:54 -0400 Min Li wrote:
> Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY
> for gettime and settime exclusively

Can you fill in more details about what the user visible problem is?
Judging by the fact that you haven't tagged the patch as 
[PATCH net-next] after my previous explanation you do think this 
is a fix. But "Add xyz support" sounds like a feature, not a fix.

> Signed-off-by: Min Li <min.li.xe@renesas.com>
> Acked-by: Richard Cochran <richardcochran@gmail.com>

> -	err = char_array_to_timespec(buf, sizeof(buf), ts);
> -
> -	return err;
> +	return char_array_to_timespec(buf, sizeof(buf), ts);

I don't think you were modifying this code, so no need to clean it up
in this commit. It's unrelated to the change you're making now.

>  }

> -	/* Re-enable extts */
> -	if (extts_mask)
> -		idtcm_enable_extts_mask(channel, extts_mask, true);
> +	err = _idtcm_gettime(channel, ts, 10);
>  
>  	return err;
>  }

Here, tho, you are changing the code, and yet you haven't done what 
I asked.