Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761587AbXEJNOO (ORCPT ); Thu, 10 May 2007 09:14:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756085AbXEJNN5 (ORCPT ); Thu, 10 May 2007 09:13:57 -0400 Received: from rtr.ca ([64.26.128.89]:1588 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755629AbXEJNN4 (ORCPT ); Thu, 10 May 2007 09:13:56 -0400 Message-ID: <46431A92.8010501@rtr.ca> Date: Thu, 10 May 2007 09:13:54 -0400 From: Mark Lord User-Agent: Thunderbird 2.0.0.0 (X11/20070326) MIME-Version: 1.0 To: Alan Cox Cc: Geert Uytterhoeven , Linux Kernel Development , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: HDIO_DRIVE_CMD and hdparm References: <20070510135153.5f6d62f8@the-village.bc.nu> In-Reply-To: <20070510135153.5f6d62f8@the-village.bc.nu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 20 Alan Cox wrote: >> - SCSI doesn't handle HDIO_DRIVE_CMD(null), and returns EINVAL >> => fine for hdparm >> - If a block device doesn't support the ioctl, blkdev_driver_ioctl() returns >> ENOTTY >> => hdparm error message > > Those are both correct > -ENOTTY I don't know this ioctl > -EINVAL I know this ioctl, usage wrong Exactly. I'll have hdparm-7.4 not complain on ENOTTY as well. -ml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/