Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757077AbXEJNXk (ORCPT ); Thu, 10 May 2007 09:23:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760216AbXEJNXb (ORCPT ); Thu, 10 May 2007 09:23:31 -0400 Received: from wr-out-0506.google.com ([64.233.184.235]:47451 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759720AbXEJNXa (ORCPT ); Thu, 10 May 2007 09:23:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=j0XHgWVSKJTD/U8fUN4bJs3Hhr9FJHxW8yaZKnfgfmSqcaTzum11Y9tUYx+bvQ0QP06tY75mXq45II+LWlLIJJXfSU3HN9dAGnYqVQ+NzwZb7VPxzaMAvqPopKpTdNeiBPZ4DSjnvbC7AS/GQ8p7Ri1kG0rPgzS0W54897mlaLk= Message-ID: Date: Thu, 10 May 2007 18:53:28 +0530 From: "Satyam Sharma" To: "Jens Axboe" Subject: Re: [PATCH 7/12] i386 sg: add support for chaining scatterlists Cc: linux-kernel@vger.kernel.org, "Andrew Morton" In-Reply-To: <11787972373410-git-send-email-jens.axboe@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <11787972373654-git-send-email-jens.axboe@oracle.com> <11787972373410-git-send-email-jens.axboe@oracle.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 21 On 5/10/07, Jens Axboe wrote: > [...] > +static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents, > + struct scatterlist *sgl) > +{ > +#ifndef ARCH_HAS_SG_CHAIN > + BUG(); > +#endif Hmmm ... so we better also make sure all users call this from within an "#ifdef ARCH_HAS_SG_CHAIN" themselves (or else make this a config option defined in the arch/.../defconfig of archs that support this and then make the calling code's Kconfig option "depends on ... && ARCH_FOO"). (Just saw a previous thread, Andrew seems to have beaten me to this observation) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/