Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2814919iob; Fri, 6 May 2022 10:58:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCJk0KGCcEEPAX0X+EqTdzTWi/bhQlkPRnKYT+p2XH/UIQNS2Ii5OCdFaaXSCspcmXsP2d X-Received: by 2002:aa7:c70f:0:b0:425:f70d:b34 with SMTP id i15-20020aa7c70f000000b00425f70d0b34mr4777894edq.306.1651859890910; Fri, 06 May 2022 10:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651859890; cv=none; d=google.com; s=arc-20160816; b=YVxwBGCMzSHQqR7v1OKoAuFS+95nR9TjQ6SPR1ckVFOS653h3e7lK0DQF6BBExvaLa 8wVvZtoiw6u3msiLSqK2YmBKvZzNgN6dCpZsA8fj2V4yrcW69oYr0Q5j3nOmfoGc5+eU GxEnNTyFRc3EzT/EAtcJXAzU30BBsgiVuNEYYSKpWjVkQ8loRAslodEgq/uNDFJKwMov CWNhWPI2VSGr+IGXNkvPvQWjAhNqKasAO4tqUMUHZUmQP8mqcHtq1OgJke4qLshvz/nm u0Rk5uH7KacHGRt/qpGNABKazhQnSRevPaqmNNss6RErFPkeWu7tXUhoM4sa/uW4vVrn e62g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sL15BtqxkS83BtwMcXzwwWefkBGsC27aYs1XXsPFiMg=; b=h6z9YIfmLv+8FB2ZBwAq1Gn8/6pnu82my8jAGiViDreNxxtCWik4K5go6Op9cNNK6l jQ++h8WrOiNFAbEvpktnSHG/4s/H2ZGWChSFLANcP2at31J2efNzsiNhp3NVlLteK8q8 qK376nImKfqzdvFJ7s0XgI1UmnjMneoo7lYR6k9VZn5fQeeZ8H7xvd76XTnLSkgC6aSB 4LdSnnlbPQMlS6EjKhJbZRQd40dS6RR06iVfjojtkhwOgBPCSsqwDVBRY3GOrf+t5ndh tVbRNKmiRh8aGgcTM2pldCmyF19TkWC5FSXKAyY3jTuDHLi5wlpz5mVyYMJoraOaFK69 jIYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=k4YcWOZ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a2-20020a170906368200b006f379ecd794si5188365ejc.478.2022.05.06.10.57.47; Fri, 06 May 2022 10:58:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=k4YcWOZ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236591AbiEEB7R (ORCPT + 99 others); Wed, 4 May 2022 21:59:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236467AbiEEB7N (ORCPT ); Wed, 4 May 2022 21:59:13 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 871D718E10; Wed, 4 May 2022 18:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=sL15BtqxkS83BtwMcXzwwWefkBGsC27aYs1XXsPFiMg=; b=k4YcWOZ0W272989cxF2N9neV80 zC0uryM6TrESFaN/7iEAyWBnYSUfQbkXa6eBVJrjLslY4Z2tW1PwlRW8InkBQ4sl8aLNmtH4+a9M7 OjY/CPuYhlH+dpD3wW2tl3QcYVqLdJnMWUgeKEU6wjn0PLHQ/j5pqeTKHnl6WMBRCesU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nmQiF-001I3B-0G; Thu, 05 May 2022 03:55:27 +0200 Date: Thu, 5 May 2022 03:55:26 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Pavel Machek , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH v6 10/11] net: dsa: qca8k: add LEDs support Message-ID: References: <20220503151633.18760-1-ansuelsmth@gmail.com> <20220503151633.18760-11-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503151633.18760-11-ansuelsmth@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + ret = fwnode_property_read_string(led, "default-state", &state); You should probably use led_default_state led_init_default_state_get() Andrew