Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762167AbXEJNYw (ORCPT ); Thu, 10 May 2007 09:24:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758487AbXEJNYo (ORCPT ); Thu, 10 May 2007 09:24:44 -0400 Received: from rtr.ca ([64.26.128.89]:3024 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755742AbXEJNYn (ORCPT ); Thu, 10 May 2007 09:24:43 -0400 Message-ID: <46431D19.1070308@rtr.ca> Date: Thu, 10 May 2007 09:24:41 -0400 From: Mark Lord User-Agent: Thunderbird 2.0.0.0 (X11/20070326) MIME-Version: 1.0 To: Tejun Heo Cc: Robert Hancock , linux-kernel , linux-ide@vger.kernel.org, Andrew Morton , Jeff Garzik Subject: Re: [PATCH] libata: add human-readable error value decoding References: <46428103.3040003@shaw.ca> <4642E92D.5010509@gmail.com> In-Reply-To: <4642E92D.5010509@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 20 Tejun Heo wrote: > Robert Hancock wrote: >> This adds human-readable decoding of the ATA status and error registers >> (similar >> to what drivers/ide does) as well as the SATA Serror register to libata ... > I'm not really convinced whether this is necessary. The human readable > form is also a bit cryptic and can get quite long. So, mild NACK from me. Same here, but I would like to see it in there under a CONFIG_DEBUG_LIBATA kernel build option or something. Kind of like the "FANCY_STATUS_DUMPS" flag that drivers/ide used to have for this kind of stuff. Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/