Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <e6837098-15d9-acb6-7e34-1923cf8c6fe1@winds.org>
 <878rri2i6o.fsf@cjr.nz> <7dc6c729-73cd-74be-eec7-ac4a0013f60f@samba.org>
 <87tua51550.fsf@cjr.nz> <df763cb0-83f2-35a5-a381-57cfd040becf@talpey.com> <87r15910c1.fsf@cjr.nz>
In-Reply-To: <87r15910c1.fsf@cjr.nz>
From:   Steve French <smfrench@gmail.com>
Date:   Thu, 5 May 2022 21:03:40 -0500
Message-ID: <CAH2r5muEMNZ8opMrkR4O5Od3W7oYmSgi9-ytQJqegF=XVJ757w@mail.gmail.com>
Subject: Re: CIFS regression mounting vers=1.0 NTLMSSP when hostname is too long
To:     Paulo Alcantara <pc@cjr.nz>
Cc:     Tom Talpey <tom@talpey.com>, Byron Stanoszek <gandalf@winds.org>,
        Shyam Prasad N <nspmangalore@gmail.com>,
        CIFS <linux-cifs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Yes - this makes sense.  Patch would be appreciated (just got back
from LSF/MM, so catching up after travel)

On Thu, May 5, 2022 at 8:59 PM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Tom Talpey <tom@talpey.com> writes:
>
> > I think the most conservative and spec-compliant choice should be made.
> > SMB1 should not be pushing the envelope of interoperability, in this day
> > and age.
>
> OK.
>
> > I believe the NetBIOS name is a fixed array of 16 octets, right? So, if
> > the nodename is shorter, it needs to be padded with 0's.
>
> Right.
>
> > Did this code change recently? Why???
>
> We used to not send the WorkstationName during NTLMSSP until recent
> patch from Shyam:
>
>         commit 49bd49f983b5026e4557d31c5d737d9657c4113e
>         Author: Shyam Prasad N <sprasad@microsoft.com>
>         Date:   Fri Nov 5 19:03:57 2021 +0000
>
>             cifs: send workstation name during ntlmssp session setup
>
>             During the ntlmssp session setup (authenticate phases)
>             send the client workstation info. This can make debugging easier on
>             servers.
>
>             Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
>             Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
>             Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de>
>             Signed-off-by: Steve French <stfrench@microsoft.com>
>
> Unfortunately some servers did not seem to enforce it to be 16 bytes
> long, so the reason why we didn't catch it earlier.
>
> Steve, Shyam, let me know if it does make sense to you and then I can
> work on a patch to fix it properly.


-- 
Thanks,

Steve