Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 May 2022 15:51:00 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Ethan Yang <etyang@sierrawireless.com>
Cc:     =?utf-8?B?55qT5a6HIO+/vQ==?= <ipis.yang@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Glen Chiang <GChiang@sierrawireless.com>
Subject: Re: [PATCH v3] usb: serial: qcserial: add support for Sierra
 Wireless EM7590
Message-ID: <YnPWRJT+NoxQcp7a@hovoldconsulting.com>
References: <YmYvPXeqQzyms91m@kroah.com>
 <20220425055840.5693-1-etyang@sierrawireless.com>
 <YnO1NHWCFCIfydBI@hovoldconsulting.com>
 <BL0PR02MB4451F88B384BA9D7FCE6A7C3ABC29@BL0PR02MB4451.namprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BL0PR02MB4451F88B384BA9D7FCE6A7C3ABC29@BL0PR02MB4451.namprd02.prod.outlook.com>
Precedence: bulk

On Thu, May 05, 2022 at 12:35:41PM +0000, Ethan Yang wrote:
> Hi Johan,
> 
> Here is the change log:
> To revise the correct composition for QDL/APP mode.
> 1199:c080 is for QDL, and 1199:c081 is for APP mode.

I meant that when you when you resend a new version of a patch you
should include a changelog for what changed since the previous
version(s) (below the --- line).

In this case I think you only changed the From address from v1 to v2,
but I'm not sure.

No need to resend, but please keep that in mind for your future
submissions.

> I also enclose the lsusb -v output for both compositions.

Thanks a lot for that.

I've applied the patch now.

Johan