Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3239737iob; Fri, 6 May 2022 23:37:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw//4stwQZ5ZtqTrQrH+BiWtfr8T0VfbwQzL+a58VUF6o0nkoIMNCpDaoDCaeUqfyxYPXFL X-Received: by 2002:a17:906:4313:b0:6b8:b3e5:a46 with SMTP id j19-20020a170906431300b006b8b3e50a46mr6016728ejm.417.1651905451762; Fri, 06 May 2022 23:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651905451; cv=none; d=google.com; s=arc-20160816; b=ys41+ItfSRmiBShb0RZf45WGqKFAX89FuW4kn2eZp9n1+OXtjP/E0nzKvZcqlNG4qQ FapS54xQqNBbze5n4ba4pa0/HdzTz5pJPUAgtAni6JcF4Jyzli/FQOGaaKeLKCB2wi9m jJYHdP5XWrf0NxZyQzpofXncsgseMz4KkhTvOlSn04D6UhNmtLZO2J+Rf4BhCbN6Pbku MH+2eLt/p3UF4kJDDCledUfWrLLEiyjgduorV2j4viDh8ZW9RxRLqanhJezFT2sshczC DI9HOk+D852OT8q75r9RawAATJ0fO5TDFZD8veruZscIYYmFStu6VzZ9YNTRk/2ByPVk 0G+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CH1//oTJwwM0nedNI1wPFEWKQoAykTzCH2IJngeHxBY=; b=Oa4PfB31bpsu6fXKBa8NilbHAhKnJ+YplECzh6XXPjCEGnzOFvJmH9aik4PirFXl0E y05whOhfYvS7XgbfZHZsbvIlaJcz5qmL2djZNuN4YLcVBKA/8BRD+9xBsGi+1JqzCk1P TuzyQ2oU5Jdtr5OmldKQZBqRwl6Ph/diLtrvQ94Ci2F+aNgXOTsGU4yJE5F3ReErlpas leUF9Yzh2Ikb7CLvxgbvBsG7AMH4uohXFP9XcrviBwtsdOA+95svIWMSzXDDNskG3TPd MBCprA3q7p17k1dWwr3eB0wnmO262DtqnQkLuLRp2ownFwB2OEwtEror1xxV4xreKcwB eHUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XwneceND; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q25-20020a170906361900b006e7f5d0f45asi6347201ejb.791.2022.05.06.23.36.40; Fri, 06 May 2022 23:37:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XwneceND; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386368AbiEEWiL (ORCPT + 99 others); Thu, 5 May 2022 18:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386356AbiEEWiI (ORCPT ); Thu, 5 May 2022 18:38:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ECCD6004D; Thu, 5 May 2022 15:34:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 10B5E61E53; Thu, 5 May 2022 22:34:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5974AC385A4; Thu, 5 May 2022 22:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651790066; bh=Fjpze9p+LviKLUP0aU8SZtUfet1POQ58RsbqdrFG4aU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XwneceNDSaXq0hOFu7m5dCZ1neE5qHMCBgJzH3zC53YNIaSFbDNDny3OnGfu2GNJg XQanp2o4W4s0eA6VsGWPNCgBGEmW9HZo1YKXAoWwYvsJL2lfK441u05n2CtAU30dMk nVi/vU5qjS8pFdXl687zzS49PRYxHKyxY4WJA8EE= Date: Thu, 5 May 2022 22:48:54 +0200 From: Greg KH To: Shubhrajyoti Datta Cc: linux-serial@vger.kernel.org, michal.simek@xilinx.com, jirislaby@kernel.org, git@xilinx.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements Message-ID: References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 01:44:15PM +0530, Shubhrajyoti Datta wrote: > Many of the stuff is reported by static analysis > changes are > > - Update the copyright text > - Check the return valuesof runtime and clock enable calls > - Check the ignore_status in the isr > - Prevent writing to the fifo when controller is disabled. > > Michal Simek (1): > xilinx: Update copyright text to correct format > > Shubhrajyoti Datta (6): > tty: xilinx_uartps: Check the clk_enable return value > tty: xilinx_uartps: Add check for runtime_get_sync calls > tty: xilinx_uartps: Check clk_enable return type > tty: xilinx_uartps: Make the timeout unsigned > serial: uartps: Fix the ignore_status > serial: uartps: Prevent writes when the controller is disabled Nit, why is the subject line prefix not unified here? Shouldn't they all be "tty: xilinx_uartps:" like 4 of them are? Can you fix up and resend? thanks, greg k-h