Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220425021407.486916-1-ian@linux.cowan.aero>
In-Reply-To: <20220425021407.486916-1-ian@linux.cowan.aero>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 6 May 2022 20:34:09 +0200
Message-ID: <CAJZ5v0hb9Goj9N+VCfAB9Fy+HA7EqG=Z+XJo1t53KcmF62-PbA@mail.gmail.com>
Subject: Re: [PATCH] drivers: acpi: clean up spaces to be consistent
To:     Ian Cowan <ian@linux.cowan.aero>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Apr 25, 2022 at 4:14 AM Ian Cowan <ian@linux.cowan.aero> wrote:
>
> This cleans up a few line spaces so that it is consistent with the rest
> of the file. There are a few places where a space was added before a
> return and two spots where a double line space was made into one line
> space.
>
> Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
> ---
>  drivers/acpi/ac.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index db487ff9dd1b..f8ec48cd7659 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -32,7 +32,6 @@ MODULE_AUTHOR("Paul Diefenbaugh");
>  MODULE_DESCRIPTION("ACPI AC Adapter Driver");
>  MODULE_LICENSE("GPL");
>
> -
>  static int acpi_ac_add(struct acpi_device *device);
>  static int acpi_ac_remove(struct acpi_device *device);
>  static void acpi_ac_notify(struct acpi_device *device, u32 event);
> @@ -125,6 +124,7 @@ static int get_ac_property(struct power_supply *psy,
>         default:
>                 return -EINVAL;
>         }
> +
>         return 0;
>  }
>
> @@ -190,12 +190,14 @@ static int acpi_ac_battery_notify(struct notifier_block *nb,
>  static int __init thinkpad_e530_quirk(const struct dmi_system_id *d)
>  {
>         ac_sleep_before_get_state_ms = 1000;
> +
>         return 0;
>  }
>
>  static int __init ac_only_quirk(const struct dmi_system_id *d)
>  {
>         ac_only = 1;
> +
>         return 0;
>  }

I don't really think that it is useful to add empty lines in the two
cases above.

The rest of the patch is fine with me.

>
> @@ -286,6 +288,7 @@ static int acpi_ac_resume(struct device *dev)
>                 return 0;
>         if (old_state != ac->state)
>                 kobject_uevent(&ac->charger->dev.kobj, KOBJ_CHANGE);
> +
>         return 0;
>  }
>  #else
> @@ -296,7 +299,6 @@ static int acpi_ac_remove(struct acpi_device *device)
>  {
>         struct acpi_ac *ac = NULL;
>
> -
>         if (!device || !acpi_driver_data(device))
>                 return -EINVAL;
>
> --
> 2.35.1
>