Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 May 2022 14:29:30 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>
Subject: Re: [RFC PATCH v6 011/104] KVM: TDX: Initialize TDX module when
 loading kvm_intel.ko
Message-ID: <20220506212930.GA2145958@private.email.ne.jp>
References: <cover.1651774250.git.isaku.yamahata@intel.com>
 <752bc449e13cb3e6874ba2d82f790f6f6018813c.1651774250.git.isaku.yamahata@intel.com>
 <c7c1f8d1-081a-d543-bdb4-6895292c7077@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c7c1f8d1-081a-d543-bdb4-6895292c7077@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, May 06, 2022 at 09:57:09PM +0800,
Xiaoyao Li <xiaoyao.li@intel.com> wrote:

> On 5/6/2022 2:14 AM, isaku.yamahata@intel.com wrote:
> > +int __init tdx_module_setup(void)
> > +{
> > +	const struct tdsysinfo_struct *tdsysinfo;
> > +	int ret = 0;
> > +
> > +	BUILD_BUG_ON(sizeof(*tdsysinfo) != 1024);
> > +	BUILD_BUG_ON(TDX_MAX_NR_CPUID_CONFIGS != 37);
> > +
> > +	ret = tdx_detect();
> > +	if (ret) {
> > +		pr_info("Failed to detect TDX module.\n");
> > +		return ret;
> > +	}
> > +
> > +	ret = tdx_init();
> > +	if (ret) {
> > +		pr_info("Failed to initialize TDX module.\n");
> > +		return ret;
> > +	}
> > +
> > +	tdsysinfo = tdx_get_sysinfo();
> > +	if (tdx_caps.nr_cpuid_configs > TDX_MAX_NR_CPUID_CONFIGS)
> > +		return -EIO;
> 
> It needs to check tdsysinfo->num_cpuid_config against
> TDX_MAX_NR_CPUID_CONFIG
> 
> or move the check down after tdx_caps is initialized.

Thanks for catching it. I'll replace it with tdsysinfo->num_cpuid_config.

-- 
Isaku Yamahata <isaku.yamahata@gmail.com>