Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 05 May 2022 11:06:05 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <313a5b2e-c571-a13f-3447-b1cd7200f4c9@linaro.org>
References: <20220430130347.15190-1-linux@fw-web.de> <20220430130347.15190-5-linux@fw-web.de> <20220504152450.cs2afa4hwkqp5b5m@skbuf> <trinity-9f557027-8e00-4a4a-bc19-bc576e163f7b-1651678399970@3c-app-gmx-bs42> <20220504154720.62cwrz7frjkjbb7u@skbuf> <313a5b2e-c571-a13f-3447-b1cd7200f4c9@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board
Reply-to: frank-w@public-files.de
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Vladimir Oltean <olteanv@gmail.com>
CC:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org,
        linux-rockchip@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <D201CE50-280C-4089-BB9F-053FEA28FE9A@public-files.de>
Precedence: bulk

Am 5=2E Mai 2022 10:46:55 MESZ schrieb Krzysztof Kozlowski <krzysztof=2Ekoz=
lowski@linaro=2Eorg>:
>On 04/05/2022 17:47, Vladimir Oltean wrote:
>>>
>>> current device-tree nodes using "switch" and "ports"
>>>
>>> see discussioon here about make it fixed to "ports" property instead
>of PatternProperties including optional "ethernet-"
>>>
>>>
>https://patchwork=2Ekernel=2Eorg/project/linux-mediatek/patch/20220502153=
238=2E85090-1-linux@fw-web=2Ede/#24843155
>>=20
>> Hmm, I don't get why Krzysztof said to just keep what is used in
>> existing device trees=2E The schema validator should describe what is
>> valid,=20
>
>These were talks about bindings which describe hardware=2E The node name,
>except Devicetree spec asking for generic names, does not matter here
>actually=2E
>
>> and since the mt7530 driver does not care one way or another
>> (some drivers do explicitly parse the "ports"/"ethernet-ports" node),
>> then whatever is valid for the DSA core is also valid for the mt7530
>> bindings=2E And "ethernet-ports" is valid too, so I think it should be
>> accepted by mediatek=2Eyaml=2E=2E=2E
>
>You can make it "(ethernet-)?ports" as well=2E My comment was purely to
>make it simpler, for bindings (goes into properties, not
>patternProperties) and for us=2E If you prefer to keep it like DSA core,
>also fine=2E

Ok, i'm also thinking, the dsa-definition will be the right way (pattern-p=
roperties with optional "ethernet-") in binding=2E

Should i use "ethernet-ports" instead of "ports" here? Current dts with mt=
7530/mt7531 switches using "ports" so i would use it here too=2E If dsa pre=
fer ethernet-ports now it should be changed in other files too=2E

>Best regards,
>Krzysztof

Hi,
regards Frank