Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7316927c-3068-90b6-3500-bf759bb46493@linaro.org>
Date:   Thu, 5 May 2022 10:37:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct
 #clock-cells
Content-Language: en-US
To:     Robert Marko <robimarko@gmail.com>, agross@kernel.org,
        bjorn.andersson@linaro.org, jassisinghbrar@gmail.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        mturquette@baylibre.com, sboyd@kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        dmitry.baryshkov@linaro.org
References: <20220503195605.4015616-1-robimarko@gmail.com>
 <20220503195605.4015616-5-robimarko@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220503195605.4015616-5-robimarko@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/05/2022 21:56, Robert Marko wrote:
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 3b5ba7ecc19d..1f803925867e 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -50,7 +50,7 @@ properties:
>      const: 1
>  
>    '#clock-cells':
> -    const: 0
> +    enum: [0, 1]
>  
>    clock-names:
>      minItems: 2
> @@ -96,6 +96,22 @@ allOf:
>        properties:
>          clocks:
>            maxItems: 3
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,ipq6018-apcs-apps-global
> +            - qcom,ipq8074-apcs-apps-global
> +    then:
> +      properties:
> +        '#clock-cells':
> +          const: 1
> +

If there is a respin, please drop this blank line.

> +    else:
> +      properties:
> +        '#clock-cells':
> +          const: 0
> +
>  examples:
>  
>    # Example apcs with msm8996


Best regards,
Krzysztof