Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
        Kashyap Desai <kashyap.desai@broadcom.com>,
        Sumit Saxena <sumit.saxena@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] scsi: mpi3mr: Replace snprintf with sysfs_emit in adp_state_show
Date:   Thu,  5 May 2022 14:17:42 +0800
Message-Id: <20220505061742.1657020-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Grb5rvuZDRh57IfW/99iSXFLLSYpamjTN5/J+d9FhCp4nJNRh18pcQKJo8cf?=
 =?us-ascii?Q?okHzE3pOetFw2DTl5NdVJ34eE+mXX4bchpx672UioKBiwf+6QY6scuGLM0S2?=
 =?us-ascii?Q?/eY/UE73TTtidj8UxbNm5SdiHoT8TYBYmyB/9/RzObEUUXnAUrcKpcqklQKg?=
 =?us-ascii?Q?KxY+nPFxiH1BGuBJpXiV2q5O0qkXvdXdHOMqXfNe7HZI654oC6CbXz4dNXXd?=
 =?us-ascii?Q?S9CXC9WIIow8ns9IvgApbiKpkSBD3cXa4ES6G0OkDYDfX6LiRgtXileXBYBJ?=
 =?us-ascii?Q?XgPObv9Oy+l402r3VIhATjmdtMAk+vCcpehBVb3MctzKh9tY+T2gi/mQn2J0?=
 =?us-ascii?Q?ewyzbn2clYfgo+Z8kU5oT5sFmL/um/Ee3GI7RYgINz3RqiHC2pKbHItIfC+U?=
 =?us-ascii?Q?xQXT7GX+Cvx0TWQED7RMlZjrka1ZL9Ne0yLhP8lt7SmEi2oQNNzSxcbJExN3?=
 =?us-ascii?Q?4rsGRcLOkLkycxzgrvfRIghdVEuN/3DBI/55w3dP1f3k0xuLD+PXyrPnI8Sw?=
 =?us-ascii?Q?AmHzcKOQQ7Fe50mtN0fhXzAgfRDpb1Dgr7tqPonpDRBv8kLvxL/KWY4jMIqQ?=
 =?us-ascii?Q?i2q6AUNZH6VF+4+xkWmj+jF0vhGxFYGFDb0H3JsI6t/EhpeQ+DUAA6ukVnCl?=
 =?us-ascii?Q?cbWz4onQ4YFQmHSj58bNo0M0b021hccpbw1jw9WaJEs6MnHLxVKH/gQ2vAsT?=
 =?us-ascii?Q?UaTqA90cQWMHPic1INoY969/AZQjJPu65vMi/30lTgieXV6WHMXeDRFHKoPT?=
 =?us-ascii?Q?0Dg1xvw2VQaB8RIfSp8QRNU4PqCFlAnZrFVwX1YpQvsutbUKsYveSGoJ9R5r?=
 =?us-ascii?Q?Nvgvy26JWdnK83r96vkQuVGfHRVZdUBzTO6kQsDu74wQerxTtuxyA95j/tFV?=
 =?us-ascii?Q?66a+JwUeXeA2EAlAleyCXPpQOT+4AW/yO59k0ev6JOjuVnhas2NerFKY+EPw?=
 =?us-ascii?Q?SMrwetsvtKNyZk437PFaIuiJ2qEIhXSJND1kQoIaMpAi13uP5wmf/lcCUcVP?=
 =?us-ascii?Q?tAChiQq2eqHxBK9kGxoiUkyMOhH2/ZrtUSKiV+Lc5C14JOq5mxMRTn3DH6Rg?=
 =?us-ascii?Q?pmEzJd+D8Qgj+aDVf1H6pz82PsXjER4WbI1aY0LAfpbUiq3ggs6zKA2XDggD?=
 =?us-ascii?Q?lJFJPetnAW3Hx68aeMPDfRmFPdvOissenVvbeJ+HA+oCC920gMDxAEx/GlcX?=
 =?us-ascii?Q?MVD1eNcxg6dDkkKbUEr+ZYqioW3I4RrZwHrMvmB5u6i8rKesr6zkFzuQlrJh?=
 =?us-ascii?Q?b7s2EQ3w4xW0QoZK1Rdue4EwUgeZVqyq+2JQnRyofUzo5A4mlUOq8gcWTyJ4?=
 =?us-ascii?Q?mH2JlCE/9H3J8FEQ58Js8Mj4XPwGM15oW49vhTOFZW5imdsRYwylkRDFFdk7?=
 =?us-ascii?Q?srpZOEOYqb6HGBwhAwMHuEF3XnbxXL/wa3TyXNnRMT5nIZrdpS2xE1VQh9f4?=
 =?us-ascii?Q?0KToRIRnyJamG1H2oxXlWQvzwLTb8n7pCZyFIoL2dCS445VQ5tWJy/TV9r7u?=
 =?us-ascii?Q?5ntvg+nrf60WOEnVJtiXY5MPzqmw0xECa168eBIaLchLS2b15GnOKuixoC1t?=
 =?us-ascii?Q?6SpxegYZvtChv1srOVftdkxLxvlvvny+CUsxbe506uJu5H5q5M8WE22v8LIZ?=
 =?us-ascii?Q?Pt7Dr9kUBJ0keVFz4FDCM9HNS2pZAZprZILvj5CxIlIu04Z0oJeh5SXCNYXm?=
 =?us-ascii?Q?L0GiCSac99E7aUiQJeG4gUQTxLpf1B1XZRbCQvkiLp38YSSlYvC3AZIfJqUy?=
 =?us-ascii?Q?xGA0SWjHfQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49d19012-650a-429d-120f-08da2e5f01de
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 06:18:02.0541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EJgJTXlYaRQahcuF39kT8nZXUdG58OFkb0mQ1ksf7iQfbuxpWhoC+VHxlFT1lEaCuMo0Oyq+w+D5oIgLrEozJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3826
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/scsi/mpi3mr/mpi3mr_app.c:1588:8-16: WARNING: use scnprintf or sprintf

Use sysfs_emit instead of snprintf and fix some comments.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/scsi/mpi3mr/mpi3mr_app.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/mpi3mr/mpi3mr_app.c b/drivers/scsi/mpi3mr/mpi3mr_app.c
index 73bb7992d5a8..86a7206548e4 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_app.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_app.c
@@ -1559,12 +1559,12 @@ void mpi3mr_bsg_init(struct mpi3mr_ioc *mrioc)
 }
 
 /**
- * adapter_state_show - SysFS callback for adapter state show
+ * adp_state_show - SysFS callback for adapter state show
  * @dev: class device
  * @attr: Device attributes
  * @buf: Buffer to copy
  *
- * Return: snprintf() return after copying adapter state
+ * Return: sysfs_emit() return after copying adapter state
  */
 static ssize_t
 adp_state_show(struct device *dev, struct device_attribute *attr,
@@ -1585,7 +1585,7 @@ adp_state_show(struct device *dev, struct device_attribute *attr,
 	else
 		adp_state = MPI3MR_BSG_ADPSTATE_OPERATIONAL;
 
-	return snprintf(buf, PAGE_SIZE, "%u\n", adp_state);
+	return sysfs_emit(buf, "%u\n", adp_state);
 }
 
 static DEVICE_ATTR_RO(adp_state);
-- 
2.36.0