Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4593204iob; Sun, 8 May 2022 18:33:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/C0jHr5ARxjLdlG29ZSsjVoiok0PcqMAv8OdHY6viAalcmZxMGSJ6nPQXMfKI6J10z4W6 X-Received: by 2002:a05:6a00:168a:b0:4f7:e161:83cd with SMTP id k10-20020a056a00168a00b004f7e16183cdmr13653625pfc.56.1652060003710; Sun, 08 May 2022 18:33:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652060003; cv=none; d=google.com; s=arc-20160816; b=aH44KcYqPfB9HzSz/ie1usS6CxzGadpVX0BF+u2rnjf1n+WtCBf5ozbDE+Z9A/APIt tILrN4ATOFLBZX3LNzv8lFNLOlml5/59Hr8OF+CDGM3tv9+sVZsK0I/BAIU0iLAR+2R/ ZoHlCNXFsTluaPt6Dw2SMgF1GDpUdwGwv/aac70+gTvLhycpJQ1Aww3qgDqty7KWlxCd l/LZvjm1kmJU8rPdk+xVQ+F4AEuCUE+dWo3agZ/2qaU71e6IVY1f3nIW8da4uitcoF47 VJ1Gnt/o1+XCZq/D2cRmddaxXQyJipREVD+XAjry/dtkaX3Jbf9v6dUVJI8bxVtN3F1/ HoOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qFzsKwjS4oTglW5oLmudZSlpGzaNmoS09xaa+tL0Y2A=; b=NyojKgpG2PpiqNU9WOp+dsR5Xc4Cp07w21JWNHCcZ2uNr5CjMtaGJwj7EfHNWSCZT5 KDNr+AggzEA8GEpBCVZU/+uO9XeomH58vVUwdFtFQIEWxb96Fqd2SiVjSePRhcmNKs/H gwvKWB7HtnA8chvY0uQD1e35bwbkJiMduy+AtFEt6zZg/JUfErpqWu2abL2g0lqnJGYo UqQhfEZs2N5XkkRuL3tjjE0++H+egmVTYRDl9rP4ImepxCH1Ah6YqXUsOLlctlRkWNjs hSff/WNGvf/KSB6+jpEUaM4kiom4Hur9nPot9blZUHA1QAQWpxY6b2cbiRkbIgGShdmr wWgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2hsQTD33; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s4-20020a655844000000b003816043f110si13537355pgr.773.2022.05.08.18.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 18:33:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2hsQTD33; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F3E4C286E1; Sun, 8 May 2022 18:33:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358962AbiEDRwx (ORCPT + 99 others); Wed, 4 May 2022 13:52:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358143AbiEDRPm (ORCPT ); Wed, 4 May 2022 13:15:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B4D4CD61; Wed, 4 May 2022 09:59:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0DC8CB8279F; Wed, 4 May 2022 16:59:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FE6DC385B2; Wed, 4 May 2022 16:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683540; bh=dyOBYSsT28SsWFTSbD01pL/bEcA04i8+1uX9QAN1emM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2hsQTD33+Ch5vnBlT86IoswgmwcdQXXy5vJ/CvcvoWYRrHJAXP5qeChBThKYZ11YA 6kzMkflRYuQ4lvL2qO8EmC1V1NykuC5CDMrbzrSSy0okTlTxBr1qTmEbSX+20OeV+1 sOERtrznEfdWf/LscXOz54Ii1ujtAenIE4EPxUr0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Starke Subject: [PATCH 5.17 211/225] tty: n_gsm: fix missing explicit ldisc flush Date: Wed, 4 May 2022 18:47:29 +0200 Message-Id: <20220504153128.840262210@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Starke commit 17eac652028501df7ea296b1d9b9c134db262b7d upstream. In gsm_cleanup_mux() the muxer is closed down and all queues are removed. However, removing the queues is done without explicit control of the underlying buffers. Flush those before freeing up our queues to ensure that all outgoing queues are cleared consistently. Otherwise, a new mux connection establishment attempt may time out while the underlying tty is still busy sending out the remaining data from the previous connection. Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") Cc: stable@vger.kernel.org Signed-off-by: Daniel Starke Link: https://lore.kernel.org/r/20220414094225.4527-10-daniel.starke@siemens.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/n_gsm.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -2152,6 +2152,7 @@ static void gsm_cleanup_mux(struct gsm_m gsm_dlci_release(gsm->dlci[i]); mutex_unlock(&gsm->mutex); /* Now wipe the queues */ + tty_ldisc_flush(gsm->tty); list_for_each_entry_safe(txq, ntxq, &gsm->tx_list, list) kfree(txq); INIT_LIST_HEAD(&gsm->tx_list);