Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220503195605.4015616-1-robimarko@gmail.com> <20220503195605.4015616-5-robimarko@gmail.com>
 <7316927c-3068-90b6-3500-bf759bb46493@linaro.org>
In-Reply-To: <7316927c-3068-90b6-3500-bf759bb46493@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Sat, 7 May 2022 22:37:58 +0200
Message-ID: <CAOX2RU6DCueDU02Qmx9xLNVP0uWX2z+3ia5Oem30gj-jdWdcQw@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        linux-clk@vger.kernel.org, dmitry.baryshkov@linaro.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 5 May 2022 at 10:37, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 03/05/2022 21:56, Robert Marko wrote:
> > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > index 3b5ba7ecc19d..1f803925867e 100644
> > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > @@ -50,7 +50,7 @@ properties:
> >      const: 1
> >
> >    '#clock-cells':
> > -    const: 0
> > +    enum: [0, 1]
> >
> >    clock-names:
> >      minItems: 2
> > @@ -96,6 +96,22 @@ allOf:
> >        properties:
> >          clocks:
> >            maxItems: 3
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - qcom,ipq6018-apcs-apps-global
> > +            - qcom,ipq8074-apcs-apps-global
> > +    then:
> > +      properties:
> > +        '#clock-cells':
> > +          const: 1
> > +
>
> If there is a respin, please drop this blank line.

Done as part of v3, thanks.

Regards,
Robert
>
> > +    else:
> > +      properties:
> > +        '#clock-cells':
> > +          const: 0
> > +
> >  examples:
> >
> >    # Example apcs with msm8996
>
>
> Best regards,
> Krzysztof