Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 06 May 2022 16:08:17 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <ac70ae6d-7e1a-d6b9-e33e-793035d5606e@linaro.org>
References: <20220505150008.126627-1-linux@fw-web.de> <6d45f060-85e6-f3ff-ef00-6c68a2ada7a1@linaro.org> <trinity-12061c77-38b6-4b56-bccd-3b54cf9dc0e8-1651819574078@3c-app-gmx-bs21> <ac70ae6d-7e1a-d6b9-e33e-793035d5606e@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Aw: Re: [RFC v2] dt-bindings: net: dsa: convert binding for mediatek switches
Reply-to: frank-w@public-files.de
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Greg Ungerer <gerg@kernel.org>,
        =?ISO-8859-1?Q?Ren=E9_van_Dorst?= <opensource@vdorst.com>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <04062F03-43DC-4B92-8C39-2F84ABDE2DE4@public-files.de>
Precedence: bulk

Am 6=2E Mai 2022 09:15:12 MESZ schrieb Krzysztof Kozlowski <krzysztof=2Ekoz=
lowski@linaro=2Eorg>:
>On 06/05/2022 08:46, Frank Wunderlich wrote:
>>>> +    const: 1
>>>> +
>>>> +  "#size-cells":
>>>> +    const: 0
>>>> +
>>>> +  core-supply:
>>>> +    description: |
>>>
>>> Drop | everywhere where it is not needed (so in all places, AFAICT)
>>=20
>> is it necessary for multiline-descriptions or is indentation enough?
>
>It's necessary only when YAML syntax characters appear in description
>or
>when you want specific formatting=2E
>
>https://elixir=2Ebootlin=2Ecom/linux/v5=2E18-rc5/source/Documentation/dev=
icetree/bindings/example-schema=2Eyaml#L97
>
>https://yaml-multiline=2Einfo/

Ok then i drop all except on examples

>>>> +
>>>> +patternProperties:
>>>
>>> patternProperties go before allOf, just after regular properties=2E
>>=20
>> after required, right?
>
>properties do not go after required, so neither patternProperties
>should=2E Something like: propertes -> patternProperties -> dependencies
>-> required -> allOf -> additionalProperties -> examples

Thx for explanation

So i end up like this:

https://github=2Ecom/frank-w/BPI-R2-4=2E14/blob/5=2E18-mt7531-mainline/Doc=
umentation/devicetree/bindings/net/dsa/mediatek%2Cmt7530=2Eyaml

Including followup (remove reset-gpios and add rgmii for mt7531)=2E

>>=20
>>>> +  "^(ethernet-)?ports$":
>>>> +    type: object
>>>
>>> Also on this level:
>>>     unevaluatedProperties: false
>>=20
>> this is imho a bit redundant because in dsa=2Eyaml (which is included
>now after patternProperties)
>> it is already set on both levels=2E
>
>dsa=2Eyaml does not set it on ethernet-ports=2E
>
>> Adding it here will fail in examples because of size/address-cells
>which are already defined in dsa=2Eyaml=2E=2E=2E
>> so i need to define them here again=2E
>
>You're right, it cannot be set here=2E

So i make no change here,right?

>Best regards,
>Krzysztof


regards Frank