Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4612611iob; Sun, 8 May 2022 19:12:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmX/7GM0YE95PQgX5CJ8mxS0LfO/dpmaEsKNKG1ae2E87UdRVTASvS1pCKJr+VTvEY/5Ds X-Received: by 2002:a62:bd14:0:b0:50d:4bec:ff78 with SMTP id a20-20020a62bd14000000b0050d4becff78mr13839060pff.71.1652062371117; Sun, 08 May 2022 19:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652062371; cv=none; d=google.com; s=arc-20160816; b=jtrezl9g3ZAodyAuGaRxMR8l7oka4irtSXQk7DN+wtf7/oKJdF+XyK4O6J+4WHZJlW Vwmig/o4r2xtVgMA2Hy3PgjQbKS2qu5j0BftSNjdJkUGm/iz6UjpXJJ6kryb5Y41BfdZ NnZ54lqvi+zjYYhm/VK3GeRDN2+CswtpWCK0ndoPGmO/CpjybPrXolJqljtNK3biZ1RL AFDukbtVKSdm6jqL3kLThSFJDKSBOZmZKK4SELHxu2VaOpN59h61Vr0sVtvlA6bV6Txu JWssOtjspdnRcqYlpIQF4CjjA4Xh9u43BnzZIgYUqATCLB5nelqVLPnkZL3WxOV/I3bt kt3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=YZkhX8VdSbRZKmQIOzgkSfpmToAIJcyGhKGvONZeKPM=; b=n3uQBWk46ePOnW4rKW9dy2De8UU6qzk8ib6/l83g9f+M7cmQFjttCTgK4hS32BUjaK c4GAntRyUuP5TrMvXuOSaqceievj3Ioc/pdlbaLUerZdhx51vxqse0AuNfrnSdYJy3Gb wfBeXgX9NdzOyd3NpmKP1ME1GP3ulaBAmSDC4u7t0Dn4kd1tAI91UxCK9ZnqyWCnZVl1 lkwksxzjFlEtbftjgLNZHwWUyJ3GsFBHpaD2uTjO+poezye7tKB7/uqoRaKMJluItjKa UxQR2MwI8aJeoIEFaSb2jQksBsCT6bsEvdt3ZtQboZvxh3aUShVXTsURfvoNlBxBcfz6 Ec5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wgm3Tdza; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id iq11-20020a17090afb4b00b001d59d8d5696si10819046pjb.153.2022.05.08.19.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 19:12:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wgm3Tdza; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 71AF250B22; Sun, 8 May 2022 19:12:44 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352083AbiEEJ0P (ORCPT + 99 others); Thu, 5 May 2022 05:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352667AbiEEJ0C (ORCPT ); Thu, 5 May 2022 05:26:02 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 499734E390 for ; Thu, 5 May 2022 02:22:23 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id i5so5241571wrc.13 for ; Thu, 05 May 2022 02:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YZkhX8VdSbRZKmQIOzgkSfpmToAIJcyGhKGvONZeKPM=; b=wgm3Tdzap7kkOBihTP6T0IhnT9G6Oc8Ge/5nUNlrSnTPInQoGJ98CKanFTwb6sMccZ 9d4KCxdg9LCYphRKvE9rvwU1++xkoof4loKmHyCYfxAY0gBFhMA3oPXw7NTjEqqxyHfC cNwAxA8oRijMoUjff4ROoa9YilWt5ieCB4F7ZaDx7bZ5NBlRq1XEjDizZ9ItDHbBrDJw rdCoDCQ1En6Y5bGPfqpHlZRcg2m4vS6Y/g4KRAX51Favpx55TneHi7u6O0EF4FPDa2B0 NZ6FEyOLhsL2fcnruWZj5H0x5LOeT1KGIGqo+XJU4paF90d6jjbgSv1wgUCBUHYfU45r HmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YZkhX8VdSbRZKmQIOzgkSfpmToAIJcyGhKGvONZeKPM=; b=WqOlfamrJULRFJpbdhZ9Uh45xTL/+k45ibr0AUXWPdG6n8sftwDr8gabKmZvcVzgjS C4NKozVTRrElm8IUUZy0IwiChzqzqcNvsAgUMe7YgEIorszOV6dsNjcN3sabfwJNs5sf x3cDMomQwhP6r2Y810EHGLMruOpf6ImV/64iQ2N8bcqKUeyPFcGB6Ochy6i4JBFUTTwG DoztMuEefGogrAtBI1fO5FM2e6uOgoEMBXQf3C+8BFwQXcRxuP//v/Phj8WguMUwb8G6 AMxmR2X5MRg8LIYwSe9elLAFSbxj3BNdyojuESheR1SPcYDqXG9PTzbOFWDRjohla/rr Bzpg== X-Gm-Message-State: AOAM533eVOOg+nNCxrqdeaAurs8wVt8ELdF5FZEUv9MfWsnGFe3n4uJD WT9jZ1EpDpA27MeHRM+1ZS9J3g== X-Received: by 2002:a05:6000:1110:b0:20a:e113:8221 with SMTP id z16-20020a056000111000b0020ae1138221mr19276809wrw.271.1651742541836; Thu, 05 May 2022 02:22:21 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o9-20020a5d4089000000b0020c5253d8d2sm779379wrp.30.2022.05.05.02.22.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 02:22:21 -0700 (PDT) Message-ID: Date: Thu, 5 May 2022 11:22:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Content-Language: en-US To: frank-w@public-files.de, Vladimir Oltean Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Matthias Brugger , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20220430130347.15190-1-linux@fw-web.de> <20220430130347.15190-5-linux@fw-web.de> <20220504152450.cs2afa4hwkqp5b5m@skbuf> <20220504154720.62cwrz7frjkjbb7u@skbuf> <313a5b2e-c571-a13f-3447-b1cd7200f4c9@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2022 11:06, Frank Wunderlich wrote: >> You can make it "(ethernet-)?ports" as well. My comment was purely to >> make it simpler, for bindings (goes into properties, not >> patternProperties) and for us. If you prefer to keep it like DSA core, >> also fine. > > Ok, i'm also thinking, the dsa-definition will be the right way (pattern-properties with optional "ethernet-") in binding. > > Should i use "ethernet-ports" instead of "ports" here? Current dts with mt7530/mt7531 switches using "ports" so i would use it here too. If dsa prefer ethernet-ports now it should be changed in other files too. I think bindings allow both, so choose something consistent with existing DTS sources. Best regards, Krzysztof