Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 5 May 2022 16:01:28 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Codrin.Ciubotariu@microchip.com
Cc:     Nicolas.Ferre@microchip.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, lars@metafoo.de,
        perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org
Subject: Re: [PATCH v3 6/6] ARM: configs: at91: sama7_defconfig: add MCHP
 PDMC and DMIC drivers
Message-ID: <YnPmyEujwByeFDdp@sirena.org.uk>
References: <20220307122202.2251639-1-codrin.ciubotariu@microchip.com>
 <20220307122202.2251639-7-codrin.ciubotariu@microchip.com>
 <d84e0e48-cf35-ae1a-e384-067d361457ba@microchip.com>
 <77c2b348-b7a6-458d-21b6-68c54efc317f@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="V6OcCftqYTAkRMmU"
Content-Disposition: inline
In-Reply-To: <77c2b348-b7a6-458d-21b6-68c54efc317f@microchip.com>
Precedence: bulk


--V6OcCftqYTAkRMmU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 05, 2022 at 02:47:04PM +0000, Codrin.Ciubotariu@microchip.com w=
rote:
> On 05.05.2022 16:58, Nicolas Ferre wrote:

> > I'm fine with that, but I see that some Kconfig entries "select" this=
=20
> > SND_SOC_DMIC directly (amd, intel, mediatek, stm).
> > If it's absolutely needed for PDMC to work, what about doing the same a=
s=20
> > it would prevent some broken configurations?

> The only way it makes sense to me to have this driver selected somewhere=
=20
> is in a sound card driver, used for a specific board, which we know it=20
> has PDM microphones. Since, for now, we use the simple sound card for=20
> our audio interfaces, we have no place to add this select.
> The reason I do not like to add this select under the controller driver,=
=20
> as some of the vendors did, is because, in the future, we might have=20
> different PDM microphones that might not work with SND_SOC_DMIC and=20
> might need a different driver.
> I don't have a strong opinion on this. If you think I am overthinking,=20
> please let me know and I will change this.

It's unlikely but possible that there could be some other device
connected (eg, you could have a DSP or something that generates PDM
output).  If the driver doesn't directly instantiate the DMIC itself
then it's probably reasonable for it to be user controllable if the DMIC
driver is there.

--V6OcCftqYTAkRMmU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJz5scACgkQJNaLcl1U
h9BoAQf/RxATTm9oBfzFYiQDmMZnY6nSvVtROk9XiCIp4BRvt4ezstNodFEGlLKQ
fWhTWfMmr7rGF9Syj1Zb6W/2Fahc/R04bml6dXcDHBKeW5a9Tnslg4U0brWHd2oT
SeE9ZVLQzoFgUcCh6DrwxpYIkfbPrZwrBS0YNHHgjw3LAc2voYJiNm8njcOXop9i
+kpz1RZs60mULxSPGoNOr/9HNfNc2H3lZcSG6ZkdjkiXMJ4TjedzB5YpaOFGrYLN
hCy9jHw/mzCFq9EnV8ubaTI05RFwIusQd0doLtRxlgrrS94+mwNqHggZLnFK95Z/
BnnQHFiY+49FUwRU4NPZhfcFayakzQ==
=TVpY
-----END PGP SIGNATURE-----

--V6OcCftqYTAkRMmU--