Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4627920iob; Sun, 8 May 2022 19:47:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ6KjPIFZhT6E57UuhXfimcwiGIve4wiBhUwLYrGTW5DQ8V86q1FISXm3qQZ/11NeuKJIN X-Received: by 2002:a17:90b:1642:b0:1dc:6419:43ff with SMTP id il2-20020a17090b164200b001dc641943ffmr16009218pjb.229.1652064441840; Sun, 08 May 2022 19:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652064441; cv=none; d=google.com; s=arc-20160816; b=Pbz8jPYx7G4K5sImDFpj63qvE97ZNhIjytkdXJHVShZ9FYDISEgRlDylSZ/+KgHXXH 4fK6h2d9ErmVAvxCTqn2mPPycrXX4zBVVY7+DeYI3v8Kfg5zbYa/92U05H1XBIB3P/Hu 3LosYfnIdPvOSCI32kLz/rLd8/QKx/bPpDPtlJmqmyGZYJWpAy0o0j91W1iKyeJUKk/T AcfMpaQVHM1rwkh+RzVEmLIj9DH8mG1GEMrL5PgvUwTjeQ+2M5Ajq1BP95i/aUS1278H MXp5ta0QqRzsk9d9VkIxgomEe9MNtwhPXvAZVdapN0YHggXYBI8v80ssiw17B+JbcaVk 0OpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=niHsYK6ii0g2fm/Uko8z8ChppInJGmiA9YPa7H0vo3Y=; b=e/fQDIXePTxSQO5FyIZzOweJUMSVeWGj//6c6CneIjt/UHmexVt7kAdAZTOHzayXWQ Y8QMA41TlC6syCwVg7vD3rDd0NDwj7+jSQ+DUKpduRWFoftl7v1djKH9ScnkhwnTkPV2 XqdsgVizu6lSVPUirsHXDKxQZmhr9SG51MHmmJwRSGKZWFJlxL2/YGc55ukvjAmcUUat piTScnY0QjtGGWBFCK2HjG5/ubCG8g5oG10EgtUvweHpQnkWmMS973GvilxqYAks/ghH lMtnbebre6JV1Sq1w10RVBBQ5uFLP33bkSAIA48slN/SEsqL1/YC7sob23fu8Vy99lM7 NkXg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n10-20020a63a50a000000b003c63bf66bd0si11476087pgf.862.2022.05.08.19.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 19:47:21 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1606034648; Sun, 8 May 2022 19:46:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391394AbiEFTuY (ORCPT + 99 others); Fri, 6 May 2022 15:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388545AbiEFTuU (ORCPT ); Fri, 6 May 2022 15:50:20 -0400 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72A0E6A06F for ; Fri, 6 May 2022 12:46:35 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VCTGrlU_1651866391; Received: from e18g06460.et15sqa.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VCTGrlU_1651866391) by smtp.aliyun-inc.com(127.0.0.1); Sat, 07 May 2022 03:46:33 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org, Chao Yu Cc: LKML , Gao Xiang Subject: [PATCH 2/3] erofs: remove obsoluted comments Date: Sat, 7 May 2022 03:46:11 +0800 Message-Id: <20220506194612.117120-2-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.24.4 In-Reply-To: <20220506194612.117120-1-hsiangkao@linux.alibaba.com> References: <20220506194612.117120-1-hsiangkao@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some comments haven't been useful anymore since the code updated. Let's drop them instead. Signed-off-by: Gao Xiang --- fs/erofs/inode.c | 5 ----- fs/erofs/internal.h | 25 ------------------------- 2 files changed, 30 deletions(-) diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index 8d3f56c6469b..8b18d57ec18f 100644 --- a/fs/erofs/inode.c +++ b/fs/erofs/inode.c @@ -8,11 +8,6 @@ #include -/* - * if inode is successfully read, return its inode page (or sometimes - * the inode payload page if it's an extended inode) in order to fill - * inline data if possible. - */ static void *erofs_read_inode(struct erofs_buf *buf, struct inode *inode, unsigned int *ofs) { diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index ce2a04836cd2..cfee49d33b95 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h @@ -397,31 +397,6 @@ extern const struct super_operations erofs_sops; extern const struct address_space_operations erofs_raw_access_aops; extern const struct address_space_operations z_erofs_aops; -/* - * Logical to physical block mapping - * - * Different with other file systems, it is used for 2 access modes: - * - * 1) RAW access mode: - * - * Users pass a valid (m_lblk, m_lofs -- usually 0) pair, - * and get the valid m_pblk, m_pofs and the longest m_len(in bytes). - * - * Note that m_lblk in the RAW access mode refers to the number of - * the compressed ondisk block rather than the uncompressed - * in-memory block for the compressed file. - * - * m_pofs equals to m_lofs except for the inline data page. - * - * 2) Normal access mode: - * - * If the inode is not compressed, it has no difference with - * the RAW access mode. However, if the inode is compressed, - * users should pass a valid (m_lblk, m_lofs) pair, and get - * the needed m_pblk, m_pofs, m_len to get the compressed data - * and the updated m_lblk, m_lofs which indicates the start - * of the corresponding uncompressed data in the file. - */ enum { BH_Encoded = BH_PrivateStart, BH_FullMapped, -- 2.24.4