Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a5f0b098-234b-7044-c6d5-ec50cff74676@amd.com>
Date:   Thu, 5 May 2022 10:57:36 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH v3 11/14] KVM: SVM: Introduce hybrid-AVIC mode
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        jon.grimm@amd.com, wei.huang2@amd.com, terry.bowman@amd.com
References: <20220504073128.12031-1-suravee.suthikulpanit@amd.com>
 <20220504073128.12031-12-suravee.suthikulpanit@amd.com>
 <fe7cd5012445a941cf55ea82871ea51157490aaa.camel@redhat.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
In-Reply-To: <fe7cd5012445a941cf55ea82871ea51157490aaa.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVJTeUczeFM0Z0d4MmRVd1BRT3o3ZDdaNldiTGYvQWdkS1gxclpSUldiSDE1?=
 =?utf-8?B?dGpuVElmZEtqMmcrSjcxVk1tMU9ZSzYwMW8rUzEyZFB6RDdoditpdDJ6RFpO?=
 =?utf-8?B?UlBRa1VWajZIYmhjTjl5TjR1cDhSZWJWaDYzc2wwNExtOEpaT3pRek85RmVU?=
 =?utf-8?B?QmUvNHh6QTVBOS9ZMThhVC9jYTJpaFdXREFNKzNYLzQwQ21kREJlUWtNeWcr?=
 =?utf-8?B?c0pUYTVkRUxQb2M0bUh6cERZam5RZFdrRUJuRG54Mzd1UlpSdmgvUG4zaTk1?=
 =?utf-8?B?OFMwcW1KV1VGTjFIT1FYSXpxc1g2empzMDljZFFzSExSbHkrSHpmYWgzNUk3?=
 =?utf-8?B?eFI0SkhWQkFLWWxjMXpZcDlrQlk1aTBHdjlEK051WFJRamZkYk1XQ01JMGJT?=
 =?utf-8?B?Z3pXZHNCREs4SmlNOVEwR3BvdTc2dkR1enhCS0NwbWNJVFkwZzFFSmlkT3Bw?=
 =?utf-8?B?bUtNcmJYb2xoYlVucXJUOUtDakEvY2pFRnlIbDdqODlyS1o4NE9ocGZMUnpa?=
 =?utf-8?B?WFdLTVdLYWRNai9nU09Td0VyaXFHd1ZxRkluSHZpaWhzSFhhQkJCUDFoMVJB?=
 =?utf-8?B?OStCZUhwZnRUK1B2RlhoRGI4UFYxSW1JV3FoOERFR1lLa3Z5T1YwQ3pwcXJQ?=
 =?utf-8?B?RFh4TFVPNFFXTDNYMG1rajdKenBOUGcwblRsT3BrZ1hjSVdObEUyMjFlTkdh?=
 =?utf-8?B?ZVhTTHpJME9EUXIxK3BmWGh5MUI4TExaQVJnS2hoVzJkbE4rSkJpUUxpYWxY?=
 =?utf-8?B?amxwYnRXVGt1a21kRnAzMDJEbnRhU29QLzVDaDcwWEpVY1Q4dFMrTGgzRlQ1?=
 =?utf-8?B?VGpoOUVZNHZnbktiR3ZDcmRrdmRUZzM0Rm1Qb2NiVnE3dFo3REwxdWc2OHBp?=
 =?utf-8?B?djRzTGZJbkE0Z20zZDdxbUc3ZmFRZFhYSyttRlB5R3FTZW41bXMySnFwZytT?=
 =?utf-8?B?dzE1S3R0eVFDL3BMQWovSXo5c1JXQUFJQWh3RktDdlBON0dlajdrMDRRU1ZJ?=
 =?utf-8?B?ZUNNbEZKeC92U1ZPOUtuZURCYWQzRHFDT25UVlo1aHFPQzBXUFZBWnlWR1BF?=
 =?utf-8?B?alF6cFF3bkZWQlBOSzNzUlRlQUM3Zk85ZVFvbzlvc2srcUs5cVNmdUNJcHZK?=
 =?utf-8?B?Q3JnLzVkZ2JubkE3WjVUN2ZyQlZlVlI4SDZUZFU5NjVRWTZjeFI2NjNJSWdB?=
 =?utf-8?B?V2VPOExMYmdUNkVFdk0vcHlHT2tFR1pzZHFRQTNUR3NLQVBCZjlqWUxhcjJQ?=
 =?utf-8?B?bGZGT3lzZVNYMGVTVXg3NmkzeGlFekpsRk5sZHZ3R1BtNCs4ZDJObnZiOVFv?=
 =?utf-8?B?QzlqR0phaklTUFQxMHQzNzNNUGd3akozNCs1cEpvdEtNRjBQNFBKalBiYWY3?=
 =?utf-8?B?NUFGeEJRamFpOGtjbktkQzFxTWg2b1doeUlzMDl4MEVUZGoxRXd1YVFKRlJP?=
 =?utf-8?B?QXV4eStvUGlwWjc3Z0pFNzUrYjZDMEhEdFJzVmJYaUNQUWlDU3hHZGZucWMy?=
 =?utf-8?B?Ty9neXV2UHhNRXdQbW4rVFlGbjhvT2lyR2prZlpFOFc4SWp0NnprUjNNWUQ2?=
 =?utf-8?B?eVpBV0Q1aURYbEw3c3hyaVI4d0pJUHlxYWxDQU1XbnVKclFvLzJkWnIzTEpI?=
 =?utf-8?B?MTJ2dHE3WTVJRURiSnFBOWJpQk9SNDdtWEwrRWIyODdRYXJTY3NldjlDNmRB?=
 =?utf-8?B?cXFrSE5kOVlkNTFkL0dWbFM0aVI5ajZUSG5IYzVZV0QrcUNwckMxaEhRVnRZ?=
 =?utf-8?B?YjdvYzlUYnlkelBlbDZHV0JEQnZnUVVYUlp5R0Q3UCtEOEVZOGVQMEdBZVM0?=
 =?utf-8?B?QmE1bHdiV0JRQUI3ZG1XM1Y1VTZaSDBDYWJJNkxaaVltNXRYb3VOcGlUTTBO?=
 =?utf-8?B?bzhzUm0wbjZ1b0pKOXgrekFUTTJsWmNVS1ZlY0ZETWx6cmw2ZjhFZWt2QVRT?=
 =?utf-8?B?czFkai93N28vYXg5M2VrbzNXaVl1TmdEeFZSQjNUZG9tSHZEZ3RHSTJZeWw1?=
 =?utf-8?B?TE8vdDN5cyt6WW4xZ3BRMGdMbDVLZ0Z0Q3FCSHExMzFJRXF4WEdRbjNDQ1Fl?=
 =?utf-8?B?OUsxd2tkNHpQTnhVK21QQkE4ZzlZeFJJTjVCWjhhRTRMRm5YMWFZSTB1VDdo?=
 =?utf-8?B?ZmRUQ2hQcUw3dnJMdlg3U05GRjQ4MXkvUGh1Q2o3WWo5L0ZScDZIWi90VHRt?=
 =?utf-8?B?UXFPL3ErdlpZOTB6Uy9Od0oxSFVlZFlQd2ZUMkRMNEhzWXVCVW9NbUJBUXB5?=
 =?utf-8?B?TGV4WkwxK3U3NDhaWTd6VmpSSkV1VjZRaDZVN3o2aGlqTCsxL2JHMjNnNHZQ?=
 =?utf-8?B?bFQ1VXMzdW1OczBFdkdVOGV6UUoyNHZnbWh1d3FueTBiSHpHUUpaZFNxVUgy?=
 =?utf-8?Q?C9P+G+Kag+hPnQK8JtLaW+C5Y+NrPdJjpcwcI2CdOnJS6?=
X-MS-Exchange-AntiSpam-MessageData-1: vv8F7zxPrUEXRw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e90ccb9-3a9b-479b-e520-08da2e4b6932
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 03:57:45.3088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A73C8usXs7jRGI5g4kr58k0ZCv1/n+TTiTxMnfpEDQkLhUS7EBrldn4yyr6C1T2WfcUoIooo0OxnY9ytBx6UkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4630
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Maxim

On 5/4/22 7:32 PM, Maxim Levitsky wrote:
> Well strictly speaking, another thing that has to be done, other that removing the inhibit,
> is to 'hide' the AVIC's private memslot if one of vCPUs is in x2apic mode,
> although not doing this doesn't cause any harm as the guest is not supposed to poke at xAPIC
> mmio even when uses x2apic, and if it does it will get the normal AVIC acceleration,
> so probably it is better to not add any more complexity and leave it like that.

Agree, I'll note this detail in the comment above.

> ... 
> BTW, hardware wise, does 'X2APIC_MODE' keeps the emulation of the AVIC mmio, or
> not?

According to the AVIC documentation, when the AVIC is configured to use x2 APIC mode
the MMIO access method will be disabled. This is consistent with the Intel x2APIC specification,
where it states "accessing the MMIO interface when in x2APIC mode, the behavior is identical
to xAPIC in globally disabled state".

Regards,
Suravee