Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 5 May 2022 22:29:16 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     Mel Gorman <mgorman@techsingularity.net>
CC:     kernel test robot <oliver.sang@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Dave Hansen" <dave.hansen@linux.intel.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Michal Hocko <mhocko@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, <lkp@lists.01.org>,
        <lkp@intel.com>, <ying.huang@intel.com>, <feng.tang@intel.com>,
        <zhengjun.xing@linux.intel.com>, <fengwei.yin@intel.com>
Subject: Re: [mm/page_alloc]  f26b3fa046:  netperf.Throughput_Mbps -18.0%
 regression
Message-ID: <YnPfPH4bbLIkCeNp@ziqianlu-desk1>
References: <20220420013526.GB14333@xsang-OptiPlex-9020>
 <YmvMDyx05UoPFtQy@ziqianlu-desk1>
 <20220429133918.GC3441@techsingularity.net>
 <YnOKWNE3PZzzohNH@ziqianlu-desk1>
 <20220505110947.GD3441@techsingularity.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220505110947.GD3441@techsingularity.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G46ZtIEd8RWENAosU8Cz5H7kNdhoX3K6ynG0Fco0AgXNgeutkZKtN35bNwLI?=
 =?us-ascii?Q?R5cSko/T9N1szSSubd9QLxPrDVfJNC7ZApUn2zVv+9Dt9cS6ZqByUCVDbq6L?=
 =?us-ascii?Q?gXwev9uQSPscv3xef35WgM2EFeMM4j0yGGmmr0rR4DyB2eHUR7tJBwLlibsz?=
 =?us-ascii?Q?rOPG5QM6CPnrp8MZKJu0SmeMKYYugSNj/wD9fDdeWYgegDnt0w8USDhQBIbQ?=
 =?us-ascii?Q?I43wiEKd5XWUV+oLzLwl+Y8+t7abGv97tHaR8FP0utJ90E+0mD2GeseZUVZI?=
 =?us-ascii?Q?qF0rBomac2GoASKrKhxGdn5fPCvsRJwuPOts5VWgZ0PcCkrvLTdX1c1EEg9L?=
 =?us-ascii?Q?0+CGW5qMscbEgSkdPCjzTtuXeYv4gt7PtHdbcugQ3nh4adnn0LZDgiaAlosO?=
 =?us-ascii?Q?4TfcnnB8NnCIWN0ZDlPPzmQGyjUlY+EZukAi8zHXgscc/BzNCySNXSAf323o?=
 =?us-ascii?Q?s6RWBXFWjN+AMjCesKY0XtvBIYz1h9shFM8QtCv4lHZQgAXBVAtrSRpYVLY5?=
 =?us-ascii?Q?+3YY3oqFXD4/gvdUAIZjGFwJMyICIR1FFilBcvHcO3BonQ1LawSTOgwn1vou?=
 =?us-ascii?Q?56hfXlzGW7Qv+FrO2BMxdXCYTEOembub+pgL5K7wtX0pdEBo12nC3P7B+P8g?=
 =?us-ascii?Q?0F7yuQBoAIqEiMQA0sskO4GRgAikDU283emnimkzhhPWLDO6OPxDDRz0DYxv?=
 =?us-ascii?Q?sMcp5oiKdeHGM9J4wwQfYnKyNK1jc8nqLsO87JhZlReS6MiRN382kjXJD4Gm?=
 =?us-ascii?Q?wCV1iRQMlW/qA0xg6kyPomy35sFDXCQTEaRJ51CDfax7eJrPFUDP3yla2cWO?=
 =?us-ascii?Q?z6quj+5hPz4B1oYSfaX+E9qEEpBSS8aZeiOhbdiqs/qIw1oePCg2T/LL/Yuj?=
 =?us-ascii?Q?pJaTJKA5A2LKeRARvxfvikdjwOF79ZjakPDx3ExXOIRiBni9SQotnPdzgpNc?=
 =?us-ascii?Q?bSwXSXwNPVVc5jscixm0gplLCqgJW4vZUDeI52ULtCysvov5PxFzsfmqwEsj?=
 =?us-ascii?Q?DOyCjVHZkKholqXxmU5MwB9LZmrKU57olTckQlbTW5Xm7Iq6ICKStQwEAn+c?=
 =?us-ascii?Q?lK/8Ew50X+jvwEgMxlk/l4GkEVLr9qObeVLzuwmFwDEgglRdv+vOI9V4wLav?=
 =?us-ascii?Q?VKknQqecAGIh84mCGJaVhVuGmMy8WtETkjX/HnTUaM5/IokSqv+CYYQJ1wBG?=
 =?us-ascii?Q?uFfuDht6ZgJDUeiYY9ck2F6NzXctnOAXFuaqT8EkgtSMDA8K0guOnwTM2ySM?=
 =?us-ascii?Q?G4I2WMZDYgzEDabnG4hALwkOlzMKtSYyA/wIYtmOnGZAARk+uqJ4iFlsE9k3?=
 =?us-ascii?Q?OUIFiGeM9uqJovThQKVwdMexuUKMxOEvn/4csmAVld6hTX3xTz0rIN41mqtF?=
 =?us-ascii?Q?bUkns0nhmP5c0rTIqznhTbUVG0LW3NUWSwh9WX/fdncxuRCT0x+wTF1PVVoT?=
 =?us-ascii?Q?KSI3O8IH13K6aUkWO8dOkxiKKXPmo9sAd2yt65O1Q/uceY9f/aUB2+uSLoIZ?=
 =?us-ascii?Q?0rnSXVZz4m4atAXEAcQ3Mm+GQyAKaReTKY/hmyeaew4nKisBQ8zeUMcrnF78?=
 =?us-ascii?Q?yULv0BlNW+zsipJ3eomBNMmGP45fr0B+BR/2slylfVIa1p8qHHi1hXwwgBI+?=
 =?us-ascii?Q?5b03dB+i89TxwwVphtjJvB1KR3yJGma9o2lWGXqmdkfIVX4lTk7Vbi/7iAll?=
 =?us-ascii?Q?a4VFLjPYIPf4ZRVCuK4eBUf35qo0je3ipOHtZxogHtEIo8tRET47C52m5MmO?=
 =?us-ascii?Q?+5t2k+wNVA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d68791a-fc66-4661-7dd2-08da2ea3a718
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 14:29:24.7105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pvrskQjynLlTM+wKypJsI0sfplEQr9M7tueMJnykq1nsKP1JfGGHNkWgIFJXgm1zxe6EclYV6un4ZBzCNiJZkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6095
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 05, 2022 at 12:09:47PM +0100, Mel Gorman wrote:
> On Thu, May 05, 2022 at 04:27:04PM +0800, Aaron Lu wrote:
> > On Fri, Apr 29, 2022 at 02:39:18PM +0100, Mel Gorman wrote:
> > > On Fri, Apr 29, 2022 at 07:29:19PM +0800, Aaron Lu wrote:
> > 
> > ... ...
> > 
> > > > The said change looks like this:
> > > > (relevant comment will have to be adjusted)
> > > > 
> > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > > > index 505d59f7d4fa..130a02af8321 100644
> > > > --- a/mm/page_alloc.c
> > > > +++ b/mm/page_alloc.c
> > > > @@ -3332,18 +3332,19 @@ static int nr_pcp_high(struct per_cpu_pages *pcp, struct zone *zone,
> > > >  		       bool free_high)
> > > >  {
> > > >  	int high = READ_ONCE(pcp->high);
> > > > +	int batch = READ_ONCE(pcp->batch);
> > > >  
> > > > -	if (unlikely(!high || free_high))
> > > > +	if (unlikely(!high))
> > > >  		return 0;
> > > >  
> > > > -	if (!test_bit(ZONE_RECLAIM_ACTIVE, &zone->flags))
> > > > -		return high;
> > > > -
> > > >  	/*
> > > >  	 * If reclaim is active, limit the number of pages that can be
> > > >  	 * stored on pcp lists
> > > >  	 */
> > > > -	return min(READ_ONCE(pcp->batch) << 2, high);
> > > > +	if (test_bit(ZONE_RECLAIM_ACTIVE, &zone->flags) || free_high)
> > > > +		return min(batch << 2, high);
> > > > +
> > > > +	return high;
> > > >  }
> > > >  
> > > >  static void free_unref_page_commit(struct page *page, int migratetype,
> > > > 
> > > > Does this look sane? If so, I can prepare a formal patch with proper
> > > > comment and changelog, thanks.
> > > 
> > > I think it looks reasonable sane. The corner case is that if
> > > ((high - (batch >> 2)) > cachesize) that the pages will not get recycled
> > 
> > When free_high is true, the above diff changed the return value of
> > nr_pcp_high() from 0 to min(batch << 2, pcp->high) so the corner case is
> > when (min(batch << 2, pcp->high) > cachesize)?
> > 
> 
> Yes. It's not perfect due to cache aliasing so the actual point where it
> matters will be variable. Whatever the value is, there a value where the
> corner case applies that pages do not get recycled quickly enough and
> are no longer cache-hot.

Understood. And as you said, it's a tradeoff.