Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758923AbXEJSAl (ORCPT ); Thu, 10 May 2007 14:00:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752318AbXEJSAe (ORCPT ); Thu, 10 May 2007 14:00:34 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:48642 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750755AbXEJSAd (ORCPT ); Thu, 10 May 2007 14:00:33 -0400 Date: Thu, 10 May 2007 11:00:31 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Yasunori Goto cc: linux-mm , Linux Kernel ML , Andrew Morton , Mel Gorman Subject: Re: [RFC] memory hotremove patch take 2 [01/10] (counter of removable page) In-Reply-To: <20070509120132.B906.Y-GOTO@jp.fujitsu.com> Message-ID: References: <20070509115506.B904.Y-GOTO@jp.fujitsu.com> <20070509120132.B906.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 35 On Wed, 9 May 2007, Yasunori Goto wrote: > > +unsigned int nr_free_movable_pages(void) > +{ > + unsigned long nr_pages = 0; > + struct zone *zone; > + int nid; > + > + for_each_online_node(nid) { > + zone = &(NODE_DATA(nid)->node_zones[ZONE_MOVABLE]); > + nr_pages += zone_page_state(zone, NR_FREE_PAGES); > + } > + return nr_pages; > +} Hmmmm... This is redoing what the vm counters already provide Could you add NR_MOVABLE_PAGES etc. instead and then let the ZVC counter logic take care of the rest? With a ZVC you will have the numbers in each zone and also in /proc/vmstat. (Additional ulterior motive: If we ever get away from ZONE_MOVABLE and make movable a portion of each zone then this will still work) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/