To: "Satyam Sharma" <satyam.sharma@gmail.com>
Cc: "Paul Mundt" <lethal@linux-sh.org>, "Roland Dreier" <rolandd@cisco.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.
References: <20070510035028.GA26453@linux-sh.org> <aday7jw29ci.fsf@cisco.com>
	<a781481a0705100511l1bfdc7f3tc2669eb916f76594@mail.gmail.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 10 May 2007 11:20:14 -0700
In-Reply-To: <a781481a0705100511l1bfdc7f3tc2669eb916f76594@mail.gmail.com> (Satyam Sharma's message of "Thu, 10 May 2007 17:41:21 +0530")
Message-ID: <ada8xbw1qxt.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 910
Lines: 17

 > IMHO default configs must be aimed at production usage scenarios, so
 > are better off without debugging enabled by default. Except if the
 > driver is really new / EXPERIMENTAL where the goal is to get it tested
 > out by all users asap (and no production systems would be using it
 > anyway).

I agree, but I would hope that MLX4_DEBUG *is* enabled in production.
It doesn't print anything or introduce any measurable overhead except
for slightly larger code size unless the debug level is explicitly
increased, so the only reason to turn it off is if a few bytes of code
makes a big difference to you (hence making it selectable only if
EMBEDDED is selected).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/