Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4639851iob; Sun, 8 May 2022 20:13:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBav/9rzLg3A6PUwbBi6XYQMGXUUUfwH791kDFcIfbMdDvMda0yx/PTymL7MCDicu2Yma5 X-Received: by 2002:a17:90a:f30d:b0:1dc:b437:4ab with SMTP id ca13-20020a17090af30d00b001dcb43704abmr24005350pjb.23.1652066035676; Sun, 08 May 2022 20:13:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652066035; cv=none; d=google.com; s=arc-20160816; b=RLvZ4KUKyDPbhpCLb6wKfpzsoOSJZYh5GKjyyD+ryTLTya+TjrFEUrTdLdETNcIVl8 o8AtIoNEtV5I5Q3DPRT51MYZPwo+ihYr7xgdq9bBfAazi7lomupdwW9nPd56bcT5TUUJ vXtWDKbkvJFJW+/F3ATS3iTcaUqj8Lq578m6hUntJF74SckFVbbakQHFrDurlOD/Gjo/ vHpw37KI++e+iL6jgqj9DKOp2/+rLO532WV5TFTVNEG7OOVnfpqqrJtiMe7Y9fDOx2CU 2HIGKhMqZvzDktC5aISySfAGd7Yxuwl/7qTizX8s0ZaPdoqVlKlDvGcIP9CezvyLT+LI vLXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=I+BA0Fo8Tt53eRixUoHaMVecXiumQenJeYSFmr5u8eA=; b=sRrcAI8h2WRVTuxNO/AOvM8J+5wyC9/rVhKuGMvcdETmOqtetHhjhZXgq/IQnBj+4u D+X8cvpOBr8xKtCesDjT2lyO9w5VNhBAMHbaeo+IgcnxFeicGsbxJw/9vsrH5DxODf9c q+KMfJrbCdbBuvhXgIMHuYd0t3R5DDFeDrbbg7T9T/fS3waKo84aXIvoFEbdRSFag0Ov xYJkGGkijs6wu1SLgDctRbTnyhwFI/kisjXA8zTmjDla9rWAGnvh1dN1fUzn/TX60ana Y39WIGSNwnLP3ckXrrxC8heK4vJNHoEsgg7M+HFrfxN6hPVVPZgAxzBpzcMj/Na9kRwx tisA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Z5i3QmAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q144-20020a632a96000000b0039cf337f6c6si12785569pgq.546.2022.05.08.20.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 20:13:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Z5i3QmAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4B01B92D27; Sun, 8 May 2022 20:13:43 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391040AbiEFKqJ (ORCPT + 99 others); Fri, 6 May 2022 06:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231283AbiEFKqF (ORCPT ); Fri, 6 May 2022 06:46:05 -0400 Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4CD0165402 for ; Fri, 6 May 2022 03:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=I+BA0 Fo8Tt53eRixUoHaMVecXiumQenJeYSFmr5u8eA=; b=Z5i3QmAWrjiK6GolasOGS eqwzgDDSpnhp7uSYthJ2hk+qoAzhk9zPJtXKRfwh0Es0k1BazNt3BvIzxhvhUeZU vQt0ZxeG++5gPPHhtjnUNKixgRFqSS/CKihpoz+EPbF90DZOoRbQ4luAegIemBEs 3P+BhoFrFpWymJsKfsxybY= Received: from localhost.localdomain (unknown [120.204.77.149]) by smtp9 (Coremail) with SMTP id DcCowABnJuNN+3RiBRE6BQ--.2127S4; Fri, 06 May 2022 18:41:52 +0800 (CST) From: lizhe To: bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, prudo@redhat.com Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lizhe Subject: [PATCH v5] kernel/crash_core.c : remove redundant check of ck_cmdline Date: Fri, 6 May 2022 03:41:16 -0700 Message-Id: <20220506104116.259323-1-sensor1010@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DcCowABnJuNN+3RiBRE6BQ--.2127S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw1kJry8Jr1fZr1xGw18AFb_yoWxCFg_Ww 48Krn2qFyUAw1j9r1xZayfWrWYkr40va9a9a43trWava4DJr1rG34rtrn0yrnrA3s7Ar17 Crs3J3ZrtrWYgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMc_T7UUUUU== X-Originating-IP: [120.204.77.149] X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/1tbiWBH4q1uHyRtwCgAAsu X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At the end of get_last_crashkernel(), the judgement of ck_cmdline is obviously unnecessary and causes redundance, let's clean it up. Signed-off-by: lizhe Acked-by: Baoquan He Acked-by: Philipp Rudo --- kernel/crash_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 256cf6db573c..c232f01a2c54 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline, p = strstr(p+1, name); } - if (!ck_cmdline) - return NULL; - return ck_cmdline; } -- 2.25.1