Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <1e4264e6-55ed-7681-0aff-ce1dd9d6fd9a@kernel.dk>
Date:   Sun, 8 May 2022 17:39:41 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] relay: remove redundant assignment to pointer buf
Content-Language: en-US
To:     Colin Ian King <colin.i.king@gmail.com>,
        Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     kernel-janitors@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
        linux-kernel@vger.kernel.org
References: <20220508212152.58753-1-colin.i.king@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220508212152.58753-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/8/22 3:21 PM, Colin Ian King wrote:
> Pointer buf is being assigned a value that is not being read, buf
> is being re-assigned in the next starement. The assignment is
> redundant and can be removed.
> 
> Cleans up clang scan build warning:
> kernel/relay.c:443:8: warning: Although the value stored to 'buf' is
> used in the enclosing expression, the value is never actually read
> from 'buf' [deadcode.DeadStores]

Andrew, I'm assuming you'll pick this up?

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe