Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <e223929f4fbbfcba51b8cc9dda6a07ace12f5dd8.camel@linux.ibm.com>
Subject: Re: [PATCH v9 6/7] ima: support fs-verity file digest based version
 3 signatures
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Stefan Berger <stefanb@linux.ibm.com>,
        linux-integrity@vger.kernel.org
Cc:     Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 06 May 2022 07:34:52 -0400
In-Reply-To: <ae5889bc-f5aa-6d0a-fdce-81819a15d22c@linux.ibm.com>
References: <20220505123141.1599622-1-zohar@linux.ibm.com>
         <20220505123141.1599622-7-zohar@linux.ibm.com>
         <ae5889bc-f5aa-6d0a-fdce-81819a15d22c@linux.ibm.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-05-05 at 13:12 -0400, Stefan Berger wrote:
> 
> On 5/5/22 08:31, Mimi Zohar wrote:
> > IMA may verify a file's integrity against a "good" value stored in the
> > 'security.ima' xattr or as an appended signature, based on policy.  When
> > the "good value" is stored in the xattr, the xattr may contain a file
> > hash or signature.  In either case, the "good" value is preceded by a
> > header.  The first byte of the xattr header indicates the type of data
> > - hash, signature - stored in the xattr.  To support storing fs-verity
> > signatures in the 'security.ima' xattr requires further differentiating
> > the fs-verity signature from the existing IMA signature.
> > 
> > In addition the signatures stored in 'security.ima' xattr, need to be
> > disambiguated.  Instead of directly signing the fs-verity digest, a new
> > signature format version 3 is defined as the hash of the ima_file_id
> > structure, which identifies the type of signature and the digest.
> > 
> > The IMA policy defines "which" files are to be measured, verified, and/or
> > audited.  For those files being verified, the policy rules indicate "how"
> > the file should be verified.  For example to require a file be signed,
> > the appraise policy rule must include the 'appraise_type' option.
> > 
> > 	appraise_type:= [imasig] | [imasig|modsig] | [sigv3]
> >             where 'imasig' is the original or signature format v2 (default),
> >             where 'modsig' is an appended signature,
> >             where 'sigv3' is the signature format v3.
> > 
> > The policy rule must also indicate the type of digest, if not the IMA
> > default, by first specifying the digest type:
> > 
> > 	digest_type:= [verity]
> > 
> > The following policy rule requires fsverity signatures.  The rule may be
> > constrained, for example based on a fsuuid or LSM label.
> > 
> >        appraise func=BPRM_CHECK digest_type=verity appraise_type=sigv3
> > 
> > Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> 
> Acked-by: Stefan Berger <stefanb@linux.ibm.com>

Thanks, Stefan!

This patch set is now queued in the next-integrity-testing branch,
waiting additional review/tags. 

thanks,

Mimi