Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 6 May 2022 17:55:59 +0900
From:   Naoya Horiguchi <naoya.horiguchi@linux.dev>
To:     zhenwei pi <pizhenwei@bytedance.com>
Cc:     akpm@linux-foundation.org, naoya.horiguchi@nec.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH 2/4] mm/memofy-failure.c:: simplify num_poisoned_pages_dec
Message-ID: <20220506085559.GB1356094@u2004>
References: <20220429142206.294714-1-pizhenwei@bytedance.com>
 <20220429142206.294714-3-pizhenwei@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220429142206.294714-3-pizhenwei@bytedance.com>
Precedence: bulk

On Fri, Apr 29, 2022 at 10:22:04PM +0800, zhenwei pi wrote:
> Don't descrease the number of poisoned pages in page_alloc.c, let the
        ^^^^
        decrease?

> memory-failure.c do inc/dec poisoned pages only.
> 
> Also simplify unpoison_memory(), only descrease the number of
                                        ^^^^
                                        same typo

> poisoned pages when:
>  - TestClearPageHWPoison() succeed
>  - put_page_back_buddy succeed
> 
> After descreasing, print necessary log.
        ^^^^
        ditto

> 
> Finally, remove clear_page_hwpoison() and unpoison_taken_off_page().
> 
> Cc: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>

Otherwise, the changes look good to me.

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>