Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 5 May 2022 14:03:30 -0700
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Fix SLS checks
Message-ID: <20220505210330.flb36r4emty2js3y@treble>
References: <Ym0UWja2L40QbgEc@hirez.programming.kicks-ass.net>
 <20220502181547.fzz2yre2p4akph4s@treble>
 <YnA8Yw19AQV28w54@hirez.programming.kicks-ass.net>
 <20220503211510.ytdv5l4l2zwjdwg7@treble>
 <YnIqt4aOooAvlja4@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YnIqt4aOooAvlja4@hirez.programming.kicks-ass.net>
Precedence: bulk

On Wed, May 04, 2022 at 09:26:47AM +0200, Peter Zijlstra wrote:
> > I don't quite follow this 2nd sentence and how it's related here, since
> > this function doesn't actually deal with direct jumps.
> 
> Ah, my bad. Also, this wrong.
> 
> I suppose this wants to be something like:
> 
> 	if (i < insn->length && op == JMP32_INSN_OPCODE)
> 		bytes[i++] = INT3_INSN_OPCODE;
> 
> So this *can* be a jump, but typically won't be I suppose.

Yep.

> > Speaking of, I guess we'll eventually need to hack this SLS mess into
> > jump labels :-/
> 
> Urgh... can't we reason that the straight line case is actually expected
> to run with the given register state anyway and ignore this?

Yeah, that makes sense.

So for jump labels the SLS path would probably not be worse than a
typical v1-style conditional branch misspeculation into the 'else' path,
and we've already given up on worrying about those anyway.

-- 
Josh