Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 6 May 2022 10:14:55 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ian Cowan <ian@linux.cowan.aero>
Cc:     Hans Verkuil <hverkuil@xs4all.nl>,
        Corentin Labbe <clabbe@baylibre.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: media: zoran: replace dprintk with new
 debugging macros
Message-ID: <20220506071455.GC4031@kadam>
References: <20220425144110.133316-1-ian@linux.cowan.aero>
 <3270dd49-0d68-5b60-d766-940b39aa463e@xs4all.nl>
 <YnSyZEF8n7luVvHM@fedora>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YnSyZEF8n7luVvHM@fedora>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6YOB8lka/flOL3sUNTctihPS5q31WwzZ/cothZDTseoPSGqgC+jRUkFvQQ7v?=
 =?us-ascii?Q?4JQ6nkBQ0S4rpt3eOM7FMmebN2d8i2/j8rafX6FJP9NsL25bMbz/o69sGvPw?=
 =?us-ascii?Q?ntrZCfhAY6wPMeH3vfQ6n+0p7BlkiFFy9z4kirRnbypjNNBJ2FkGkEeL+Vfz?=
 =?us-ascii?Q?bjOw9JCiiFJml1AE5qPQ2L6D5YLqNbweXU+PwJ0xiVEi0U6QHrlW32YhnBbW?=
 =?us-ascii?Q?WUhesSLiYEX6u4u7WgGB61ozQGAT2SgmACcBGpdCSNs5H+rO44S5V/N12K36?=
 =?us-ascii?Q?O92K29WDMAgAOt1NDnXVGvFazd++H9j6wEK+rrJn9GwDXLgrJvfNhJDl15eE?=
 =?us-ascii?Q?+ywk5kHKjBq4IXVfeQNfz3qZVVmPSa848qAgdcK8Yl7avsGdQjOmhNFB5sBc?=
 =?us-ascii?Q?EGDPpeFQ/KjOPPlXwNm6aRPBz9JByp55I+LdW1+xhUNJ/GqEi0L3qU7exn9t?=
 =?us-ascii?Q?8U5UPgCs3j+5EP3+6IxzHV+ZSrpzeMNFYE9MQnpZh3S4HNvG40HSK1DiEFfY?=
 =?us-ascii?Q?res6CoRdffCwD7yAnT7OttQmq0zV9Uco7l/IJIpRRtl2xRGAF+x1Elxb1qfG?=
 =?us-ascii?Q?HSByZQQjPgKUJUT3pQW6Ptzu33ihcEZtR2ULAZ9mp3Su0UozZYsfil7G8m1S?=
 =?us-ascii?Q?6C/8ljUs+NT4UgUN9SEyckWRUb9GNdEOKVhnz1TcZDwiIQjElnWlUPsghIIl?=
 =?us-ascii?Q?oc9ibWRcKFWILYAWH3B34KL6W4DKXSA5gllFoT8df3k459JfjXk86UXdIk1X?=
 =?us-ascii?Q?S2McFFBNOZY9j0Na43PM50+W0OX42ALMu/H4xgNC687VVoXS/gd/Rj5bX+Tv?=
 =?us-ascii?Q?YOsZlA6rfUwwW8AWgweAWkqSuqD7uyKkTO9E6ZC5sZ+EarzpWQhrXvHWl3ra?=
 =?us-ascii?Q?8q7UouT5qk5kIRpsCl5VcxYoXjMYyc754//I2HEBJZqM1LMeaK9Lv3KsMHad?=
 =?us-ascii?Q?CZ9YfeF6rzyYM4j0gyyGoyDH2y8paolskubwReM0/SvySB2kQmrFFhprs26k?=
 =?us-ascii?Q?Y2MYvWRpFU4yTROeAH4Idlyp9W4UXMFn4t5ivd2IErwA1Hfe9jFa/WhklSRJ?=
 =?us-ascii?Q?zooHqoWhLQ6+7n+dMkICqeKhF5np6awc6pyysbZpZ4IsE8e4QR4WKKY4DpF+?=
 =?us-ascii?Q?s/ERKNQlvvQyYFSb+Nwsp0BpLaFjneb58Rx/l/TI6z3cK3Jv2IBwlyCr+Oth?=
 =?us-ascii?Q?eGPW4tKdkV4AUXSxGpOSiCZu+Yl0G9NShgwHZ/bQvRFMCKCsojMyQUY+4bRB?=
 =?us-ascii?Q?jFaIJzPxcVRDtn24w3yDs1c96dJo47KQqf46FdgvbXSvciQLxLet5JcycOe8?=
 =?us-ascii?Q?k8/U3Umukn8MciT3vGhSdZGKSIpcVG9KrJ7J61JjBoU0ZDjgXScpKbj0A+As?=
 =?us-ascii?Q?/FYGhNInsTclZxwQ5+ND+93qA/S2/bQiuQXs96K8fTu5PKTt+5H7HcYa4WnG?=
 =?us-ascii?Q?fJkG899X0yhVJpuEwXtzc5v1MPUt+ADqcIHgAk0V3ZBGn8ctwQPxq38d1rjE?=
 =?us-ascii?Q?YKekSxCC0fReUf0Dy5qrwAsGQB1fftoeN75J42FAJZPnIJx+wzg+xC2fMwFx?=
 =?us-ascii?Q?kJRsodbmi5jKRFlkTW+bUWB6XIresTSrAz71JF57x8jocTec35Kr9wk1Dd6u?=
 =?us-ascii?Q?keHsu+p+l9Wbw3RoAERDgst3JcaiybIeK69JSNyhalW4OZu7d2GVl5sYijar?=
 =?us-ascii?Q?bFsCPn+d4WE4P5f0HJarGI5KIzXWvJyNxxiudUWFtlJwpQPeJABJGLqbBxlH?=
 =?us-ascii?Q?d/AB6mNbPUsB8EBgRNKuT/Be4LXJrWo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bbcbb6e-80f2-4713-6b30-08da2f302b22
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 07:15:15.9176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ia/hB4DWXIQRmqaVyA/slJMdnUErWewrAZF0rZovHIGprUSnPUp0Qo72oABuD0GbNU2EhPN3HYknCzJJyhRSPiN+DdiPDiu195OSV683j/o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB2022
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-06_02:2022-05-05,2022-05-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 bulkscore=0 suspectscore=0 mlxlogscore=861 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205060038
X-Proofpoint-GUID: QRUMUZpbZ0fO_X-4T1B3j7vdYnPtFPpX
X-Proofpoint-ORIG-GUID: QRUMUZpbZ0fO_X-4T1B3j7vdYnPtFPpX
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,
	URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 06, 2022 at 01:30:12AM -0400, Ian Cowan wrote:
> On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> > Hi Ian,
> > 
> > When I compiled this patch series with smatch I got these warnings:
> > 
> > zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced before check 'master' (see line 40)
> > zoran/videocodec.c:115 videocodec_detach() warn: variable dereferenced before check 'codec' (see line 111)
> > zoran/videocodec.c:168 videocodec_register() warn: variable dereferenced before check 'codec' (see line 166)
> > zoran/videocodec.c:200 videocodec_unregister() warn: variable dereferenced before check 'codec' (see line 198)
> > 
> > And I also got this warning when checking the kerneldoc:
> > 
> > zoran/zoran.h:307: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > 
> > Can you fix this and post a v3?
> > 
> > Thanks!
> > 
> > 	Hans
> 
> I just resubmitted v3.
> 
> What did you use to see these issues? When I ran the checkpatch script
> and compiled, I did not see any of this.
> 

I have written a blog entry about checking kernel code with Smatch:

https://staticthinking.wordpress.com/2022/04/25/how-to-run-smatch-on-your-code/

regards,
dan carpenter