Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4676044iob; Sun, 8 May 2022 21:35:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUTDIJtrPlZdhfFsgclhRIq0woxrgsUIcqbU0HKUX0AOeObZNP/GUwQ7mfTDSMhjc0yag+ X-Received: by 2002:a62:be14:0:b0:505:a43b:cf6e with SMTP id l20-20020a62be14000000b00505a43bcf6emr14348550pff.33.1652070923654; Sun, 08 May 2022 21:35:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652070923; cv=none; d=google.com; s=arc-20160816; b=Loo6U2ZcoIAhbAsnno4nUdpWfPPv8B0R50IMRJfSiAaCjrh4lhq6QnJypQx+IdtG82 hDiWGB7+nSxmS+XTrJAfGV6Wt+LnDIuLZ306cVenwTAeYo2ncX+rjZoq2NqyNWCAtWRz WMbRvm2IvX68DqsEHL3/MlMya2OUNMiC2Bi4Qn2aYSRKdhwTzu1k96qqlfLEATL102y3 1rtYSZ0/4QVrXhagTOpDUObFP0V8xC780gndoaUy652Nwv/FqBYe5FzgIG22UL6kFYqq mQTx59gfCoip+xTfa/waL4LkftWMIPjDv9AeFP6d6vEg0Vx+I4aGAbtWTG/N0I3cPLv+ 4Ijw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KGczJJutVezC/1xFFzaX2wkcWxiHzDGUjQceuVC7O4M=; b=sy+f2GmhA/FidHFbmDDs5PPFHmiAvIWsljBMvzhGTCYOY1/sNl9fHK1nnKyGdgRTwq FDxn/2Tr7HQVeyo4b/zlOT7m82dx0brN+RVROO1bCPuGieghM1062q+0azvnYfs5LAVM ttj+3VfCXd5QD1g3fnXMqEwrLSLjrHDc4jSUjP2XVjmnRGAz4HFUn7geefdcDmL+w9FH Wb/hKy1EaacQehcFpb05ymJG7pbIDtK2oXWSZxl+6B1tqoYYkI4zSyLTw0LRBEwYvgqs 06yL0nI2PS9VBn2PJXqoTahT+kr9SPdZqCrKmxP6R19/5917eFfhJnyTdwA6mrPtHCbZ gPHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mqcwhHHA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id g17-20020a056a001a1100b004fa3a8e0083si13727444pfv.314.2022.05.08.21.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 21:35:23 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mqcwhHHA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EB5F1128152; Sun, 8 May 2022 21:34:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442820AbiEFP3s (ORCPT + 99 others); Fri, 6 May 2022 11:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236859AbiEFP3r (ORCPT ); Fri, 6 May 2022 11:29:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 622DC68984 for ; Fri, 6 May 2022 08:26:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F31B5621D0 for ; Fri, 6 May 2022 15:26:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3053DC385A9; Fri, 6 May 2022 15:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651850763; bh=yPObXMYAtH1m+T5Wk5sN2N5msoIrkMz64KtalD501rY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mqcwhHHAz8MPjKWeZuQeAdE9Mf7AjfOyaf2nUOJ7tendma/QzhFAri56SFXKTjfxH QSZwsXtoh+Sh2WjQ2l32BUTxDnImPKqcPcyLzWFtFU1g0qjvoTrpsJn1xg2lh7V7Xk nuO4oIIq9nJyWzm190rCxHorVfamK0dAIinQ3u1VZ4MxE74uh272/l5jRql6qaX255 mUnMdRL7RZ5luETXkbOJdiR2SESA5sZ0EZQ5MwraR//GFRfHgIN890o93jUhXujfOe qnYj4Qne6uI/MjGOzo8/O740URvoQtSNsZ29Xn1HNOJR6DdYAi/8PRmiXvorb3OBGm XJSXInuFRsV1g== Date: Fri, 6 May 2022 08:26:01 -0700 From: Josh Poimboeuf To: Kaiwan N Billimoria Cc: Josh Poimboeuf , Peter Zijlstra , Linux Kernel Mailing List Subject: Re: [PATCH] scripts/faddr2line: Only use text symbols to calculate function size Message-ID: <20220506152601.z4f3bachnyfeqgzf@treble> References: <2fb2bc4e857848c83cfa96483e4b25b23d46be49.1651516951.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2022 at 11:34:00AM +0530, Kaiwan N Billimoria wrote: > Hi Josh, > > Unfortunately, it didn't work with my test case (as before): > $ <...>/linux-5.10.60/scripts/faddr2line ./oops_tryv2.ko do_the_work+0x124 > bad symbol size: base: 0x0000000000000000 end: 0x0000000000000000 > $ > > What _did_ work was the earlier (much longer) patch you'd sent (your > email dt 20 Jan 2022), > Could you pl recheck... > (As before, i have the test case module here: > https://github.com/PacktPublishing/Linux-Kernel-Debugging/tree/main/ch7/oops_tryv2 Sorry, I totally managed to forget that I rewrote the whole script: https://lkml.kernel.org/lkml/20220120171751.gibauc4zovoskjns@treble IIRC, that was the one that fixed your issue. Let me go clean that one up... -- Josh