Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <2fb2bc4e857848c83cfa96483e4b25b23d46be49.1651516951.git.jpoimboe@redhat.com>
 <CAPDLWs_aOi-f801SAhA1X2YH4XE_r5P3AfPV1uhQWA10bKKffg@mail.gmail.com> <20220506152601.z4f3bachnyfeqgzf@treble>
In-Reply-To: <20220506152601.z4f3bachnyfeqgzf@treble>
From:   Kaiwan N Billimoria <kaiwan.billimoria@gmail.com>
Date:   Sat, 7 May 2022 06:59:08 +0530
Message-ID: <CAPDLWs8+=z_h8or4Yz_3aJUp7M=5O=SodjEgTyau6XQkRcW8yQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/faddr2line: Only use text symbols to calculate
 function size
To:     Josh Poimboeuf <jpoimboe@kernel.org>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 6, 2022 at 8:56 PM Josh Poimboeuf <jpoimboe@kernel.org> wrote:
>
> On Fri, May 06, 2022 at 11:34:00AM +0530, Kaiwan N Billimoria wrote:
> > Hi Josh,
> >
> > Unfortunately, it didn't work with my test case (as before):
> > $ <...>/linux-5.10.60/scripts/faddr2line ./oops_tryv2.ko do_the_work+0x124
> > bad symbol size: base: 0x0000000000000000 end: 0x0000000000000000
> > $
> >
> > What _did_ work was the earlier (much longer) patch you'd sent (your
> > email dt 20 Jan 2022),
> > Could you pl recheck...
> > (As before, i have the test case module here:
> > https://github.com/PacktPublishing/Linux-Kernel-Debugging/tree/main/ch7/oops_tryv2
>
> Sorry, I totally managed to forget that I rewrote the whole script:
>
>   https://lkml.kernel.org/lkml/20220120171751.gibauc4zovoskjns@treble
>
> IIRC, that was the one that fixed your issue.  Let me go clean that one
> up...
Yup ! that's the one

>
> --
> Josh