Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4683579iob; Sun, 8 May 2022 21:53:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxt43227kpBv8tiMymjIWt3/E7zh2Fu9YlA7tSA8n70p7ERXkvnd1chKZfa5DOMRsdVSIS/ X-Received: by 2002:a17:90a:c797:b0:1d9:2764:a83b with SMTP id gn23-20020a17090ac79700b001d92764a83bmr24309609pjb.5.1652072031353; Sun, 08 May 2022 21:53:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652072031; cv=none; d=google.com; s=arc-20160816; b=IEEjzpUWAsuONRsuTILIsVj9FMEFW0/ZUVdoRUUIp+1NVk9U35XLXnLql7USqcWUaF xroXajkuZJB/1x8IMvNM6V2TVAc6lE5UGFm0Siin0olsLBzUAm1idkDtxrDGoF6lKr1m nILj0GSvwxMhG3KzEgVVCg379evGfjSm1KfCuc5QnYVtzLM8E1hwwCDy8aVwbOmp9MID DWhidSQQK6ogmPSB/NBZf1Z/YkDnG65Lc7TpsW0soTs2OMaGoQxaevVMaKFbUkWg4qJ5 b4JELTWPb8rU1vy9cIhjw83xnBEhD32i6aP+nLJ0cnPBaIz09ywDd3axa1M1xetXXIef DdCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=abJ1CFUHPWWe/a1dadFeZx4NpJai5KQEduuMYZGItoQ=; b=vIajg4UFiwVMik68uDnFojT+CxH4FyD6jqgKtOSBkc3l8ygT9CQPZoHOui1c6Cqzqo unUdVrQWzZqsWuCCsd4b7fE21/+frViZ+2UGSYS3AM8YxX7m/Y5NG4XfoZmhX5Pun2o7 JfyAlmcLf3y6FAW5qRV/D8REAuOxat3gW5Cn2DFxjFjV/A+7szkoakpaMhx04y2UwnUb lphQRwj7yjsWcvt4rjhyfQUFeQFrr7uoGsMvFIcGnIe7zvT+UyrWrwLBg60yZYxttNkh +q5LpgiJAiXLeMJ20SMa2kD7ujdvIfa5wgW2T6tyLeex/+PLOCHVz+5R79F41+2c5b7j MP1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l5mYY+ge; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p185-20020a62d0c2000000b005108b38be1csi8041369pfg.80.2022.05.08.21.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 21:53:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l5mYY+ge; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C8AFBF688E; Sun, 8 May 2022 21:53:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358256AbiEDRux (ORCPT + 99 others); Wed, 4 May 2022 13:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356319AbiEDRL6 (ORCPT ); Wed, 4 May 2022 13:11:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8119A4B1FC; Wed, 4 May 2022 09:57:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1A453B8279A; Wed, 4 May 2022 16:57:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1AC7C385A4; Wed, 4 May 2022 16:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683465; bh=vzEX6Tq9n68EdutGIw5T+UJNk47l/3TGbuch2cwKSbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l5mYY+gemsorkHfQI0IbgWOqJpq+bvTfyhY5Dyaf0eUWclUlDUP5REWWIaVpGlz1+ tW1XkK2wAdKvoPCT3HTuk2Xx0BSxjKvfuw1Zq4kXUMV1mQLbJrEhX71Sm1ASC5LdW7 xlYA64NNCLO71EWalheyIkc4a6dtvwEYXRkfsQXc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Samuel Holland , Jernej Skrabec , Sasha Levin Subject: [PATCH 5.17 127/225] clk: sunxi: sun9i-mmc: check return value after calling platform_get_resource() Date: Wed, 4 May 2022 18:46:05 +0200 Message-Id: <20220504153121.720337444@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit f58ca215cda1975f77b2b762903684a3c101bec9 ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Fixes: 7a6fca879f59 ("clk: sunxi: Add driver for A80 MMC config clocks/resets") Signed-off-by: Yang Yingliang Reviewed-by: Samuel Holland Signed-off-by: Jernej Skrabec Link: https://lore.kernel.org/r/20220421134308.2885094-1-yangyingliang@huawei.com Signed-off-by: Sasha Levin --- drivers/clk/sunxi/clk-sun9i-mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c index 542b31d6e96d..636bcf2439ef 100644 --- a/drivers/clk/sunxi/clk-sun9i-mmc.c +++ b/drivers/clk/sunxi/clk-sun9i-mmc.c @@ -109,6 +109,8 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev) spin_lock_init(&data->lock); r = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!r) + return -EINVAL; /* one clock/reset pair per word */ count = DIV_ROUND_UP((resource_size(r)), SUN9I_MMC_WIDTH); data->membase = devm_ioremap_resource(&pdev->dev, r); -- 2.35.1