Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760505AbXEJUbb (ORCPT ); Thu, 10 May 2007 16:31:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755592AbXEJUbY (ORCPT ); Thu, 10 May 2007 16:31:24 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:57326 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755016AbXEJUbY (ORCPT ); Thu, 10 May 2007 16:31:24 -0400 Date: Thu, 10 May 2007 13:31:21 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Andrew Morton cc: Hugh Dickins , Linus Torvalds , Andi Kleen , William Lee Irwin III , linux-kernel@vger.kernel.org, David Miller Subject: Re: slub-i386-support.patch In-Reply-To: <20070510131724.150e1e99.akpm@linux-foundation.org> Message-ID: References: <20070510131724.150e1e99.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 22 On Thu, 10 May 2007, Andrew Morton wrote: > > Though when I look at the patchset (copied below), I do wonder why > > it puts a quicklist_trim() into i386's cpu_idle() and flush_tlb_mm(): > > neither is where I'd expect us to be secretly freeing pages. Ah, > > several arches do it in cpu_idle(): how odd, oh well. > > Christoph, could you please check that this is justified? This has been that way for years for ia64 and sparc64. quicklist page freeing needs to be synced with the tlb flushing since page table pages may be flushed with the pages gathered in the tlb_mm struct. Dave Miller set this up initially as far as I can tell. He could probably give more details on why this was done historically. ccing Dave. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/