Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 08 May 2022 08:24:37 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <06157623-4b9c-6f26-e963-432c75cfc9e5@linaro.org>
References: <20220507170440.64005-1-linux@fw-web.de> <20220507170440.64005-6-linux@fw-web.de> <06157623-4b9c-6f26-e963-432c75cfc9e5@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v3 5/6] dt-bindings: net: dsa: make reset optional and add rgmii-mode to mt7531
Reply-to: frank-w@public-files.de
To:     linux-rockchip@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org
CC:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Greg Ungerer <gerg@kernel.org>,
        =?ISO-8859-1?Q?Ren=E9_van_Dorst?= <opensource@vdorst.com>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <DC0D3996-DFFE-4E71-B843-8D34C613D498@public-files.de>
Precedence: bulk

Am 7=2E Mai 2022 22:01:22 MESZ schrieb Krzysztof Kozlowski <krzysztof=2Ekoz=
lowski@linaro=2Eorg>:
>On 07/05/2022 19:04, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files=2Ede>
>>=20
>> Make reset optional as driver already supports it,=20
>
>I do not see the connection between hardware needing or not needing a
>reset GPIO and a driver supporting it or not=2E=2E=2E What does it mean?

My board has a shared gpio-reset between gmac and switch, so both will res=
etted if it is asserted=2E Currently it is set to the gmac and is aquired e=
xclusive=2E Adding it to switch results in 2 problems:

- due to exclusive and already mapped to gmac, switch driver exits as it c=
annot get the reset-gpio again=2E
- if i drop the reset from gmac and add to switch, it resets the gmac and =
this takes too long for switch to get up=2E Of course i can increase the wa=
it time after reset,but dropping reset here was the easier way=2E

Using reset only on gmac side brings the switch up=2E

>> allow port 5 as
>> cpu-port=20
>
>How do you allow it here?

Argh, seems i accidentally removed this part and have not recognized while=
 checking :(

It should only change description of reg for ports to:

"Port address described must be 5 or 6 for CPU port and from 0 to 5 for us=
er ports=2E"

regards Frank