Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 5 May 2022 13:19:09 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Stefan Binding <sbinding@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
Subject: Re: [PATCH v1 1/3] ASoC: cs42l42: Move CS42L42 register descriptions
 to general include
Message-ID: <YnPAvXKWtQsF2PG9@sirena.org.uk>
References: <20220504161236.2490532-1-sbinding@opensource.cirrus.com>
 <20220504161236.2490532-2-sbinding@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="A49oNdcvS3T/SemI"
Content-Disposition: inline
In-Reply-To: <20220504161236.2490532-2-sbinding@opensource.cirrus.com>
Precedence: bulk


--A49oNdcvS3T/SemI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 04, 2022 at 05:12:34PM +0100, Stefan Binding wrote:
> This is to allow the hda driver to have access to the register names,
> for improved maintainability.
> Also ensure new header is aligned to 100 columns.
>=20
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
>  include/sound/cs42l42.h    | 810 ++++++++++++++++++++++++++++++++++++
>  sound/soc/codecs/cs42l42.h | 826 +------------------------------------
>  2 files changed, 812 insertions(+), 824 deletions(-)
>  create mode 100644 include/sound/cs42l42.h

You should use git format-patch -M for things like this, it makes the
diff more legible though in this case the fact that you've mixed content
changes in with the rename will not help - those are separate changes
and it's hard to verify things as they are.  Still, seems to be OK

Acked-by: Mark Brown <broonie@kernel.org>

--A49oNdcvS3T/SemI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJzwLwACgkQJNaLcl1U
h9BkLAf+OrsVZZEPmUrcKrQLRqlrVd/1go4OcsbERWqbpsQ2yNYSvmqoIhBiQzaD
66NmRTKs/bPVqTpHcoGJwRYojKjs82/47E8ouFV13AhAsFyYvzuHqrPtNr3EO4RV
zBaWwQ9uwjolqJ/FaPOe5oUyDByhkwAWLXyUK5E9jBv9X/7fgyt/B4Xd90PB9xS4
r+i3HoHL/OTWM8XTyOrMMCQj+vQYtGaWbSES9D2UiK97b4gIUtV2LxmX1s0Ab1+T
mBAZnHxUnHxdc4XkWEJXSLlcqPu4NUd2UzS46SsqQ8efk9pqTAlaj9ztLqOtH+tA
XGHI3MjAAcZ84SgKNbfHqGnJNPDgMw==
=CS0+
-----END PGP SIGNATURE-----

--A49oNdcvS3T/SemI--