Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4703160iob; Sun, 8 May 2022 22:35:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWm70kmCAzsEWdd9O5OW1EnsyobxRDdf7fhSyE2v5M4ibkRM8uCdKn5MCBybMnSTrMDUdT X-Received: by 2002:a05:6e02:1b8a:b0:2cf:7255:d2d0 with SMTP id h10-20020a056e021b8a00b002cf7255d2d0mr6014801ili.142.1652074522463; Sun, 08 May 2022 22:35:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652074522; cv=none; d=google.com; s=arc-20160816; b=g9Fv9qCkO6EGgO9U72zoAvtQ4Eoj2Y+hu01P1C+rMWAAWl0T3s+TXCWhhkZYI1XTGx 3Gayt6xTn5T8lAIWGfMG1sz0Fz8Su7QOB65Hmr47EgdctD/tXlDfnDla24v7clojYVPq QvAWNT/YlzuHBVZgLtVdUH23O/Qkfyq9K7tot2qHwDQ3eyjQfkEIcXKovG5GkKNQTL/m gbNpbH2mQyYDqlWalQkKykxlKIRVXLEH0a34p8xo6Cj2QpvSzhTz+srbL37A5o3HE/O7 h6AF8r4oKLrmosDlQRpVgAKzKScDeMOwM9NJju9J/nQOv61LUOTu1ww6VJQ9rHMxQ64P YB/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=2yeHXcVS0xEf1KJhrNwVYrxZOdekp+t5YFLjh00tbo0=; b=Ydu6jK/U9/htHQzkjZgbdUfpQ9NEyc+tZvRK7PvuJAXGhoJWUE2YpOH3MCfvuwIPDZ yC0FPMEFp7weC/GjiS0udU/m2RcpD/0VnM+PXdcR0JscOkieMSIRHy0zX4++YvszZ1qy JDu1RTdhZ3teLGjZa9NHvwc2YQoNypSIGFmGpG8b+TncVNTttSDvfEPLW4E6KkS/pCzc dFqaIMC+PNUPOr9SaAjNq1Vn3MMRLvPg+GxjYl/07rBlMf0BiWu3TKRgPFi/SAVdE73x BArj8mWNgC4hxVBxkbk+/XvYnsShUuMxprTCjr7rcsLfdeyUYGq94owQUstqEf76bzqY Kukg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id s13-20020a02ad0d000000b0032b82812bb8si6538058jan.30.2022.05.08.22.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 22:35:22 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D13CD154026; Sun, 8 May 2022 22:35:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445465AbiEGDqY (ORCPT + 99 others); Fri, 6 May 2022 23:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232700AbiEGDqW (ORCPT ); Fri, 6 May 2022 23:46:22 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E5C736152; Fri, 6 May 2022 20:42:36 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R251e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VCUhPF._1651894943; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VCUhPF._1651894943) by smtp.aliyun-inc.com(127.0.0.1); Sat, 07 May 2022 11:42:32 +0800 From: Jiapeng Chong To: ralf@linux-mips.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] [NET] ROSE: Remove unused code and clean up some inconsistent indenting Date: Sat, 7 May 2022 11:42:07 +0800 Message-Id: <20220507034207.18651-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the follow smatch warning: net/rose/rose_route.c:1136 rose_node_show() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- net/rose/rose_route.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c index e2e6b6b78578..fee6409c2bb3 100644 --- a/net/rose/rose_route.c +++ b/net/rose/rose_route.c @@ -1128,22 +1128,15 @@ static int rose_node_show(struct seq_file *seq, void *v) seq_puts(seq, "address mask n neigh neigh neigh\n"); else { const struct rose_node *rose_node = v; - /* if (rose_node->loopback) { - seq_printf(seq, "%-10s %04d 1 loopback\n", - rose2asc(rsbuf, &rose_node->address), - rose_node->mask); - } else { */ - seq_printf(seq, "%-10s %04d %d", - rose2asc(rsbuf, &rose_node->address), - rose_node->mask, - rose_node->count); - - for (i = 0; i < rose_node->count; i++) - seq_printf(seq, " %05d", - rose_node->neighbour[i]->number); - - seq_puts(seq, "\n"); - /* } */ + seq_printf(seq, "%-10s %04d %d", + rose2asc(rsbuf, &rose_node->address), + rose_node->mask, + rose_node->count); + + for (i = 0; i < rose_node->count; i++) + seq_printf(seq, " %05d", rose_node->neighbour[i]->number); + + seq_puts(seq, "\n"); } return 0; } -- 2.20.1.7.g153144c