Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <0a3e8894-bc12-5854-dbaf-71ac8f1367f2@canonical.com>
Date:   Fri, 6 May 2022 11:22:11 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] docs: sched: Update sched-rt-group Documentation For
 Gender Inclusiveness
Content-Language: en-US
To:     Phil Auld <pauld@redhat.com>
Cc:     linux-kernel@vger.kernel.org, corbet@lwn.net,
        linux-doc@vger.kernel.org, stable@vger.kernel.org,
        peterz@infradead.org, tglx@linutronix.de
References: <20220505021424.12656-1-joseph.salisbury@canonical.com>
 <YnUwsnt52aB0sZi0@lorien.usersys.redhat.com>
From:   Joseph Salisbury <joseph.salisbury@canonical.com>
In-Reply-To: <YnUwsnt52aB0sZi0@lorien.usersys.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/6/22 10:29, Phil Auld wrote:
> On Wed, May 04, 2022 at 10:14:24PM -0400 Joseph Salisbury wrote:
>> Document assumes root user is he:
>> "assumes root knows what he is doing."
>>
>> Update documentation for inclusivness, since root is not limited by gender.
>>
>> Fixes: 60aa605dfce2 ("sched: rt: document the risk of small values in the bandwidth settings")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> ---
>>   Documentation/scheduler/sched-rt-group.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
>> index 655a096ec8fb..e55fee6772c4 100644
>> --- a/Documentation/scheduler/sched-rt-group.rst
>> +++ b/Documentation/scheduler/sched-rt-group.rst
>> @@ -19,7 +19,7 @@ Real-Time group scheduling
>>   ==========
>>   
>>    Fiddling with these settings can result in an unstable system, the knobs are
>> - root only and assumes root knows what he is doing.
>> + root only and assumes root knows what they are doing.
>>
> Now there's a singular vs plural problem.
>
> "... assumes root users know ..."  ?
Thanks for the feedback, Phil.

Your suggestion makes more sense.  I'll wait for any additional 
responses before sending a v2 with your suggestion.
>
>
>
> Cheers,
> Phil
>
>>   Most notable:
>>   
>> -- 
>> 2.34.1
>>