Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <8b1cfefa-da7d-3376-cf04-1ff77dab8170@openvz.org>
Date:   Sun, 8 May 2022 01:28:58 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH mm] tracing: incorrect gfp_t conversion
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, kernel@openvz.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <e1c09bbb-2c58-a986-c704-1db538da905a@openvz.org>
 <331d88fe-f4f7-657c-02a2-d977f15fbff6@openvz.org>
 <20220507123728.f20d977eba9fbb66bddee722@linux-foundation.org>
From:   Vasily Averin <vvs@openvz.org>
In-Reply-To: <20220507123728.f20d977eba9fbb66bddee722@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/7/22 22:37, Andrew Morton wrote:
> On Sat, 7 May 2022 22:02:05 +0300 Vasily Averin <vvs@openvz.org> wrote:
>> +	{(__force unsigned long)GFP_KERNEL,		"GFP_KERNEL"},		\
>> +	{(__force unsigned long)GFP_NOFS,		"GFP_NOFS"},		\
> 
> This got all repetitive, line-wrappy and ugly :(
> 
> What do we think of something silly like this?

> --- a/include/trace/events/mmflags.h~tracing-incorrect-gfp_t-conversion-fix
> +++ a/include/trace/events/mmflags.h
> @@ -13,53 +13,57 @@
>   * Thus most bits set go first.
>   */
>  
> +#define FUL __force unsigned long
> +
>  #define __def_gfpflag_names						\
> -	{(__force unsigned long)GFP_TRANSHUGE,		"GFP_TRANSHUGE"},	\
> -	{(__force unsigned long)GFP_TRANSHUGE_LIGHT,	"GFP_TRANSHUGE_LIGHT"}, \
...
> +	{(FUL)GFP_TRANSHUGE,		"GFP_TRANSHUGE"},	\
> +	{(FUL)GFP_TRANSHUGE_LIGHT,	"GFP_TRANSHUGE_LIGHT"}, \


I think it's a good idea, and I regret it was your idea and not mine.

Should I resend my patch with these changes or would you prefer 
to keep your patch as a separate one?

Thank you,
	Vasily Averin