Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4709728iob; Sun, 8 May 2022 22:51:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJGPxZJJI4bJ/UpDM6vujuUi9rmsFQfExJcLnv1MBTepLFcKIMnvyvgYfcqH+rIZs/9hA5 X-Received: by 2002:a05:6a00:806:b0:50d:dd03:a03a with SMTP id m6-20020a056a00080600b0050ddd03a03amr14293981pfk.57.1652075464692; Sun, 08 May 2022 22:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652075464; cv=none; d=google.com; s=arc-20160816; b=pCkIpqLChfDULcnrVRWLLviUbnApLUjxj2YRCBWN8LsaWm4oULJYh2aaXJCPUB4Pkk uPIhNq4yPWUC+0QbcP1R9DSDwFFG8GQ+Ytqh1MwcP1aDZrRVhIwqxFS+ygy3DwMHaYvo I64Sm3kMZ+XQm+H7TsKmNCP4LN7vLI5LzWuClr/c1Yyah5JN3PFVWVI9XGV8RpkHKvqA 3wAjVD3ElztBrXP7yLy4rxkcBz4Atf6AWvPeWSqCRHALvX+SePKrPCKLEXEjcbOeur0Q faONGs8MFwWMpWP38TTZNOqge1q2nRNJBUxNQ7FR5rApWSOLVOY1NnAXR/3BMGYhafuj if0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=I+BA0Fo8Tt53eRixUoHaMVecXiumQenJeYSFmr5u8eA=; b=X9l8mT4dWX+qGA3+7QQhZs76FJVmDHr9JwUdMgsnsevPEKCtNP+FTyBTF1SzHj9uaz MoTXD6RMI8pfVGmEzuA6UdSNDgTi5VZM/MpkhLmsP1ENP6cUm0v8uP2wSI5o+qmViE2l fbHAB7Kokm6m9meT39sSNQhR8OmnbQkN+ILqu6JXT6IPMnggu/SdbhIodd588SZr+e8V hZxhiGAqgwaXoNUounvVfJbmb8jGjkl6DYsBdYay4snYsDvR3eEef6Q5wHNFnzBpfdOy vaP2VpvTdd95yKslGqyu6F3iz8sbjTIFS/qFVpXJTAiq8Nbk4DpsHC0HQMVLYlk2FvBQ bNXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Mklypg5o; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i11-20020a17090332cb00b0015164c6214bsi12442196plr.2.2022.05.08.22.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 22:51:04 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Mklypg5o; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B65ED1566FE; Sun, 8 May 2022 22:47:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384327AbiEFEhS (ORCPT + 99 others); Fri, 6 May 2022 00:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbiEFEhR (ORCPT ); Fri, 6 May 2022 00:37:17 -0400 Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4FF6E140A3 for ; Thu, 5 May 2022 21:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=I+BA0 Fo8Tt53eRixUoHaMVecXiumQenJeYSFmr5u8eA=; b=Mklypg5opnwq+m/LU57xw +TbxEInMknU4ILfDjepQ335DCIMGdeX94TJukpEqtF9X64Rqt/qP6RnNnFjT1nqo J+0LNttfLEm4J79hvRnaclJzTZcVLPk3xi4xyKKByJYB6ROZAqp+9FMJMhPmuffL 4IXA/2o7/s8ocdaL1hCEPs= Received: from localhost.localdomain (unknown [120.204.77.149]) by smtp8 (Coremail) with SMTP id DMCowAB3zhrcpHRi95dhBA--.20067S4; Fri, 06 May 2022 12:33:08 +0800 (CST) From: lizhe To: bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, prudo@redhat.com Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lizhe Subject: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline Date: Thu, 5 May 2022 21:32:26 -0700 Message-Id: <20220506043226.125611-1-sensor1010@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: DMCowAB3zhrcpHRi95dhBA--.20067S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw1kJry8Jr1fZr1xGw18AFb_yoWxCFg_Ww 48Krn2qFyUAw1j9r1xZayfWrWYkr40va9a9a43trWava4DJr1rG34rtrn0yrnrA3s7Ar17 Crs3J3ZrtrWYgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_sqWUUUUUU== X-Originating-IP: [120.204.77.149] X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/xS2BdAT4q1gi2I-xYAAAsf X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At the end of get_last_crashkernel(), the judgement of ck_cmdline is obviously unnecessary and causes redundance, let's clean it up. Signed-off-by: lizhe Acked-by: Baoquan He Acked-by: Philipp Rudo --- kernel/crash_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 256cf6db573c..c232f01a2c54 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline, p = strstr(p+1, name); } - if (!ck_cmdline) - return NULL; - return ck_cmdline; } -- 2.25.1