Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761601AbXEJVAy (ORCPT ); Thu, 10 May 2007 17:00:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759631AbXEJVAl (ORCPT ); Thu, 10 May 2007 17:00:41 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:56290 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759587AbXEJVAj (ORCPT ); Thu, 10 May 2007 17:00:39 -0400 Date: Thu, 10 May 2007 23:01:34 +0200 From: Sam Ravnborg To: David Miller , cw@f00f.org, linux-kernel@vger.kernel.org Subject: Re: (hacky) [PATCH] silence MODPOST section mismatch warnings Message-ID: <20070510210134.GA23149@uranus.ravnborg.org> References: <20070510203417.GA23019@tuatara.stupidest.org> <20070510.135147.55726615.davem@davemloft.net> <20070510205427.GF29713@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070510205427.GF29713@flint.arm.linux.org.uk> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 48 On Thu, May 10, 2007 at 09:54:27PM +0100, Russell King wrote: > On Thu, May 10, 2007 at 01:51:47PM -0700, David Miller wrote: > > From: Chris Wedgwood > > Date: Thu, 10 May 2007 13:34:18 -0700 > > > > > MODPOST seems to be spewing bogus warnings. It's not clear how best > > > to fix it so perhaps we should silence it for now? > > > > Most of them are legitimate, the only one that needs sorting > > is the mm/slab.c case and people are working on that. > > > > The rest are useful and I've been working to fix things up > > on sparc64 and the networking, and in fact I'm very happy > > about these notifications. > > > > Please don't apply a sledgehammer to this issue, thanks. > > I've not had one accurate one on ARM yet. You had one patch from me in latest submission to linus that was a clear bug. > > Here's another example: > > WARNING: init/built-in.o - Section mismatch: reference to .init.text: > from .text between 'rest_init' (at offset 0x4c) and 'run_init_process' > > from init/main.c: > > static void noinline rest_init(void) > __releases(kernel_lock) > > static void run_init_process(char *init_filename) > > Clearly, it just does _not_ work. As I have already explained to you this is a binutils issue that causes this false positive. The plan is to annotate functions that are not __init that they intentional reference a function or data in a init section. I just not there yet. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/