Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <69b622c0-550b-f562-eb1e-7614e97acc25@redhat.com>
Date:   Fri, 6 May 2022 12:09:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [RFC PATCH pdx86-platform-drivers-x86] platform/x86:
 thinkpad_acpi: quirk_btusb_bug can be static
Content-Language: en-US
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        kernel test robot <lkp@intel.com>
Cc:     "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <202205031944.EP1ElC1B-lkp@intel.com>
 <YnEPbSO2rBJq37Ez@74ccfaeec2ea>
 <BL1PR12MB5157478736D9C5E82B4D9B1DE2C09@BL1PR12MB5157.namprd12.prod.outlook.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <BL1PR12MB5157478736D9C5E82B4D9B1DE2C09@BL1PR12MB5157.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 5/3/22 15:07, Limonciello, Mario wrote:
> [Public]
> 
> 
> 
>> -----Original Message-----
>> From: kernel test robot <lkp@intel.com>
>> Sent: Tuesday, May 3, 2022 06:18
>> To: Limonciello, Mario <Mario.Limonciello@amd.com>
>> Cc: kbuild-all@lists.01.org; Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com>; Hans de Goede
>> <hdegoede@redhat.com>; linux-kernel@vger.kernel.org
>> Subject: [RFC PATCH pdx86-platform-drivers-x86] platform/x86:
>> thinkpad_acpi: quirk_btusb_bug can be static
>>
>> drivers/platform/x86/thinkpad_acpi.c:317:20: warning: symbol
>> 'quirk_btusb_bug' was not declared. Should it be static?
>>
>> Fixes: 25eecc2ff6cc ("platform/x86: thinkpad_acpi: Convert btusb DMI list to
>> quirks")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks, since the original patch was still in my review-hans
branch (and not yet in for-next) I've squashed this fix into
the original patch.

Regards,

Hans


> 
>> ---
>>  drivers/platform/x86/thinkpad_acpi.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c
>> b/drivers/platform/x86/thinkpad_acpi.c
>> index aed17d32ed84b..eefa22e86ae10 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -314,7 +314,7 @@ struct quirk_entry {
>>  	bool btusb_bug;
>>  };
>>
>> -struct quirk_entry quirk_btusb_bug = {
>> +static struct quirk_entry quirk_btusb_bug = {
>>  	.btusb_bug = true,
>>  };
>>
>